Unable to build node.js in Windows with VS2022

[sabari-srk]

Version

v22.16.0

Platform

Microsoft Windows NT 10.0.22631.0
x64

Subsystem

v8

What steps will reproduce the bug?

I have got the prerequisite by running the command

winget configure ..configurations\configuration.dsc.yaml

I have cloned the repo and tried .\vcbuild as mentioned in
https://github.com/nodejs/node/blob/v22.16.0/BUILDING.md#building-nodejs-2

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Node.js should build in Windows as expected

What do you see instead?

Additional information

No response

[StefanStojanovic]

Thanks for reporting this. Can you please provide us with the full log from running vcbuild.bat? I'd also advise running git clean -fdx prior to rerunning the build command.

[sabari-srk]

output.txt

Thanks for the reply ! I'm attaching the log from running the vcbuild.bat , Hope that helps :)

[StefanStojanovic]

Thanks for the log. At first, I couldn't reproduce it, but I can now. This is a VS2022 version 17.14-specific compiler issue. With Node.js v24, we switched to compilation with ClangCL, and one of the reasons was issues like this (we had some problems with VS 17.10 and 17.12, if I recall correctly) that were typically in the V8 part of the code.

Our CI machines do not use v17.14, thus this issue is not noticeable there (same as me, I was at 17.13 too). The fix seems to be a one-liner, as that got me through the compilation, but I still need to test it. Starting from Node.js v24, we should not have more issues like this, as Clang is what the V8 project uses in their CI too. LTS branches are the only ones that will require fixes like this.

[sabari-srk]

Thanks for the information. Will the fix be merged in the upcoming versions of the LTS branch?

Also I will try to compile the same version of Node.js with a older VS2022 version (eg:17.8) and let you know if it works.

[sabari-srk]

I have tried compiling Node.js v22.16.0 with VS2022 v17.8
And I am still unable to compile , Can you let me know if the fix will be available for the future LTS releases ?

Or if you could suggest me some workaround to compile the same with this existing setup that would be good too.
Thanks in advance!

[StefanStojanovic]

It is understandable it fails to compile with that old version of VS2022. The reason is V8 changes, as with each V8 update, we make changes to enable the compilation with the currently used version of VS, and 17.8 is old. About the fix, since this is a compilation thing, fixing it is not urgent (as it works in the CI), but it would be good to have that fix in there anyway.

Since you want to compile it locally, this is the patch that would make the compilation pass. It should make it's way into some of the future releases, but until then, feel free to use it locally:

From d1a8925af16badd85fbff2c2f92d3b9bdde3bd57 Mon Sep 17 00:00:00 2001
From: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Fri, 27 Jun 2025 09:22:02 +0200
Subject: [PATCH] workaround

---
 deps/v8/src/heap/cppgc/marking-state.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/deps/v8/src/heap/cppgc/marking-state.h b/deps/v8/src/heap/cppgc/marking-state.h
index 4ce1ce40741..3153407f4f2 100644
--- a/deps/v8/src/heap/cppgc/marking-state.h
+++ b/deps/v8/src/heap/cppgc/marking-state.h
@@ -342,7 +342,7 @@ class MutatorMarkingState final : public BasicMarkingState {
   ~MutatorMarkingState() override = default;
 
   inline bool MarkNoPush(HeapObjectHeader& header) {
-    return MutatorMarkingState::BasicMarkingState::MarkNoPush(header);
+    return BasicMarkingState::MarkNoPush(header);
   }
 
   inline void ReTraceMarkedWeakContainer(cppgc::Visitor&, HeapObjectHeader&);
-- 
2.50.0.windows.1

[tom-acco]

An alternative (no code change) workaround which worked for me was to use clang.

.\vcbuild.bat clang-cl <....other args>