Distinguish different types of Nix paths at the type level

- Added distinct token and node types for different path varieties:
  - PathAbs: Absolute paths starting with `/` (e.g., `/nix/store/...`)
  - PathRel: Relative paths (e.g., `./foo`, `foo/bar`)
  - PathHome: Home-relative paths starting with `~/` (e.g., `~/foo/bar`)
  - PathSearch: NIX_PATH expressions (e.g., `<nixpkgs>`)

- Created `InterpolatablePath` trait for paths that support interpolation
  (all except search paths)

- Added helper methods to path content for easier path type checking and
  access through `match_path`, `is_search`, `is_interpolatable`, etc.

This allows code to determine what kind of path it's dealing with without
having to re-parse the path string, improving type safety, correctness,
and making path-specific operations more explicit.

Author: domenkozar

flake.lock

@@ -5,6 +5,8 @@ mod interpol;
 mod nodes;
 mod operators;
 mod path_util;
+
+pub use path_util::{Path, PathNode};
 mod str_util;
 mod tokens;
 

src/ast.rs

@@ -176,7 +176,10 @@ node! {
         IfElse,
         Select,
         Str,
-        Path,
+        PathAbs,
+        PathRel,
+        PathHome,
+        PathSearch,
         Literal,
         Lambda,
         LegacyLet,
@@ -279,7 +282,20 @@ impl InheritFrom {
     tg! { r_paren_token, ')' }
 }
 
-node! { #[from(NODE_PATH)] struct Path; }
+node! { #[from(NODE_PATH_ABS)]    struct PathAbs; }
+node! { #[from(NODE_PATH_REL)]    struct PathRel; }
+node! { #[from(NODE_PATH_HOME)]   struct PathHome; }
+node! { #[from(NODE_PATH_SEARCH)] struct PathSearch; }
+
+node! {
+    #[from(
+        PathAbs,
+        PathRel,
+        PathHome,
+        PathSearch,
+    )]
+    enum Path;
+}
 
 node! { #[from(NODE_STRING)] struct Str; }
 

src/ast/nodes.rs

@@ -1,65 +1,214 @@
-use crate::{ast::AstToken, kinds::SyntaxKind::*};
+use crate::kinds::SyntaxKind::{TOKEN_PATH_ABS, TOKEN_PATH_HOME, TOKEN_PATH_REL};
+
 use rowan::{ast::AstNode as OtherAstNode, NodeOrToken};
 
+pub use super::nodes::Path;
+use super::{
+    nodes::{PathAbs, PathHome, PathRel, PathSearch},
+    AstToken, InterpolPart, PathContent,
+};
 use crate::ast;
 
-use super::{InterpolPart, PathContent};
+/// Base trait for all path node types
+pub trait PathNode: ast::AstNode {}
+
+impl PathNode for PathAbs {}
+impl PathNode for PathRel {}
+impl PathNode for PathHome {}
+impl PathNode for PathSearch {}
+impl PathNode for Path {}
 
-impl ast::nodes::Path {
-    pub fn parts(&self) -> impl Iterator<Item = InterpolPart<PathContent>> {
-        self.syntax().children_with_tokens().map(|child| match child {
+
+fn extract_path_parts<T: ast::AstNode>(node: &T) -> Vec<InterpolPart<PathContent>> {
+    node.syntax()
+        .children_with_tokens()
+        .map(|child| match child {
             NodeOrToken::Token(token) => {
-                assert_eq!(token.kind(), TOKEN_PATH);
+                debug_assert!(matches!(
+                    token.kind(),
+                    TOKEN_PATH_ABS | TOKEN_PATH_REL | TOKEN_PATH_HOME
+                ));
                 InterpolPart::Literal(PathContent::cast(token).unwrap())
             }
             NodeOrToken::Node(node) => {
                 InterpolPart::Interpolation(ast::Interpol::cast(node.clone()).unwrap())
             }
         })
+        .collect()
+}
+
+// Direct methods for interpolatable path types
+impl PathAbs {
+    pub fn parts(&self) -> Vec<InterpolPart<PathContent>> {
+        extract_path_parts(self)
+    }
+}
+
+impl PathRel {
+    pub fn parts(&self) -> Vec<InterpolPart<PathContent>> {
+        extract_path_parts(self)
+    }
+}
+
+impl PathHome {
+    pub fn parts(&self) -> Vec<InterpolPart<PathContent>> {
+        extract_path_parts(self)
+    }
+}
+
+// Direct methods for search path
+impl PathSearch {
+    /// Get the content of a search path
+    pub fn content(&self) -> Option<PathContent> {
+        self.syntax()
+            .children_with_tokens()
+            .filter_map(|child| child.into_token().and_then(PathContent::cast))
+            .next()
+    }
+}
+
+/// Extension methods for the Path enum
+impl Path {
+    /// Get parts from any path type in a unified way
+    pub fn parts(&self) -> Vec<InterpolPart<PathContent>> {
+        match self {
+            // For interpolatable paths, get their parts
+            Path::PathAbs(p) => p.parts(),
+            Path::PathRel(p) => p.parts(),
+            Path::PathHome(p) => p.parts(),
+            // For search paths, return a single literal component if content exists
+            Path::PathSearch(p) => {
+                if let Some(content) = p.content() {
+                    vec![InterpolPart::Literal(content)]
+                } else {
+                    vec![]
+                }
+            }
+        }
+    }
+
+    pub fn is_search(&self) -> bool {
+        matches!(self, Path::PathSearch(_))
+    }
+
+    pub fn is_interpolatable(&self) -> bool {
+        !self.is_search()
     }
 }
 
 #[cfg(test)]
 mod tests {
     use rowan::ast::AstNode;
 
+    use super::InterpolPart;
     use crate::{
-        ast::{self, AstToken, InterpolPart, PathContent},
+        ast::{self, Path},
         Root,
     };
 
     #[test]
-    fn parts() {
-        fn assert_eq_ast_ctn(it: &mut dyn Iterator<Item = InterpolPart<PathContent>>, x: &str) {
-            let tmp = it.next().expect("unexpected EOF");
-            if let InterpolPart::Interpolation(astn) = tmp {
-                assert_eq!(astn.expr().unwrap().syntax().to_string(), x);
-            } else {
-                unreachable!("unexpected literal {:?}", tmp);
+    fn test_path_types() {
+        // Absolute path
+        let inp = "/foo/bar";
+        let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
+        if let ast::Expr::PathAbs(p) = expr {
+            let path = Path::cast(p.syntax().clone()).unwrap();
+            assert!(path.is_interpolatable());
+            assert!(!path.is_search());
+        }
+
+        // Search path
+        let inp = "<nixpkgs>";
+        let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
+        if let ast::Expr::PathSearch(p) = expr {
+            let path = Path::cast(p.syntax().clone()).unwrap();
+            assert!(!path.is_interpolatable());
+            assert!(path.is_search());
+        }
+    }
+
+    #[test]
+    fn test_parts() {
+        // Test parts with absolute path
+        let inp = "/foo/bar";
+        let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
+        if let ast::Expr::PathAbs(p) = expr {
+            let path = Path::cast(p.syntax().clone()).unwrap();
+
+            let parts = path.parts();
+            assert_eq!(parts.len(), 1);
+
+            match &parts[0] {
+                InterpolPart::Literal(content) => {
+                    assert_eq!(content.text(), "/foo/bar");
+                }
+                _ => panic!("Expected literal part"),
+            }
+        }
+
+        // Test parts with interpolated path
+        let inp = r#"./a/${"hello"}"#;
+        let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
+        if let ast::Expr::PathRel(p) = expr {
+            let path = Path::cast(p.syntax().clone()).unwrap();
+
+            let parts = path.parts();
+            assert_eq!(parts.len(), 2);
+
+            match &parts[0] {
+                InterpolPart::Literal(content) => {
+                    assert_eq!(content.text(), "./a/");
+                }
+                _ => panic!("Expected literal part"),
+            }
+
+            match &parts[1] {
+                InterpolPart::Interpolation(_) => {} // Success
+                _ => panic!("Expected interpolation part"),
             }
         }
 
-        fn assert_eq_lit(it: &mut dyn Iterator<Item = InterpolPart<PathContent>>, x: &str) {
-            let tmp = it.next().expect("unexpected EOF");
-            if let InterpolPart::Literal(astn) = tmp {
-                assert_eq!(astn.syntax().text(), x);
-            } else {
-                unreachable!("unexpected interpol {:?}", tmp);
+        // Test parts with search path
+        let inp = "<nixpkgs>";
+        let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
+        if let ast::Expr::PathSearch(p) = expr {
+            let path = Path::cast(p.syntax().clone()).unwrap();
+
+            let parts = path.parts();
+            assert_eq!(parts.len(), 1);
+
+            match &parts[0] {
+                InterpolPart::Literal(content) => {
+                    assert_eq!(content.text(), "<nixpkgs>");
+                }
+                _ => panic!("Expected literal part"),
             }
         }
+    }
 
-        let inp = r#"./a/b/${"c"}/${d}/e/f"#;
+    #[test]
+    fn direct_method_usage() {
+        // Test direct parts() method on PathAbs
+        let inp = "/foo/bar";
         let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
-        match expr {
-            ast::Expr::Path(p) => {
-                let mut it = p.parts();
-                assert_eq_lit(&mut it, "./a/b/");
-                assert_eq_ast_ctn(&mut it, "\"c\"");
-                assert_eq_lit(&mut it, "/");
-                assert_eq_ast_ctn(&mut it, "d");
-                assert_eq_lit(&mut it, "/e/f");
+        if let ast::Expr::PathAbs(p) = expr {
+            let parts = p.parts();
+            assert_eq!(parts.len(), 1);
+
+            match &parts[0] {
+                InterpolPart::Literal(content) => {
+                    assert_eq!(content.text(), "/foo/bar");
+                }
+                _ => panic!("Expected literal part"),
             }
-            _ => unreachable!(),
+        }
+
+        // Test direct content() method on PathSearch
+        let inp = "<nixpkgs>";
+        let expr = Root::parse(inp).ok().unwrap().expr().unwrap();
+        if let ast::Expr::PathSearch(p) = expr {
+            let content = p.content().expect("Expected content");
+            assert_eq!(content.text(), "<nixpkgs>");
         }
     }
-}
+}