-
Notifications
You must be signed in to change notification settings - Fork 59
Provide wrapper for functions that modify inputs #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In #623 you mentioned a check at the end of the task to see whether the task has altered its input hash. I think this is a good idea. Should that be included in this issue or in a separate one? |
I think it makes sense as part of this issue. Good catch. |
#791 is related to this issue I think |
#784 would also help mitigate this problem by preventing the workflow execution to break and allowing us to raise a warning about future false-negative cache misses |
Probably should be addressed at the same time as #791 |
In #623, @tclose added a function that modifies its input as a reliable reproducer of a task whose input hash changes after execution, resulting in a deadlocked workflow as the task is complete but its results are no longer findable in the cache directory.
In a comment I proposed an addition to the
pydra.mark
module:If someone has an unsafe function, they're going to need to either rewrite or wrap it themselves, or we can provide a standard tool with straightforward semantics:
So we could write:
And if somebody has control over the function but is lazy or (more charitably) finds an explicit copy cluttering, they could write:
The text was updated successfully, but these errors were encountered: