Merge pull request #82 from yurykabanov/fix-get-all-records

nilportugues · web-flow · commit ea00a1969caa · 2016-08-02T11:37:45.000+01:00
Fix issue with retrieving every single id to count them (fix #81)
diff --git a/src/NilPortugues/Laravel5/JsonApi/Controller/JsonApiTrait.php b/src/NilPortugues/Laravel5/JsonApi/Controller/JsonApiTrait.php
@@ -63,7 +63,7 @@ protected function totalAmountResourceCallable()
         return function () {
             $idKey = $this->getDataModel()->getKeyName();
 
-            return $this->getDataModel()->query()->get([$idKey])->count();
+            return $this->getDataModel()->query()->count([$idKey]);
         };
     }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ protected function totalAmountResourceCallable()`
`63`	`63`	`return function () {`
`64`	`64`	`$idKey = $this->getDataModel()->getKeyName();`
`65`	`65`
`66`		`- return $this->getDataModel()->query()->get([$idKey])->count();`
	`66`	`+ return $this->getDataModel()->query()->count([$idKey]);`
`67`	`67`	`};`
`68`	`68`	`}`
`69`	`69`