Notion Focus Bug in AeroSpace 0.18

[FelixLisczyk]

Hey there! I've run into an issue with AeroSpace since upgrading to version 0.18. The issue does not occur in earlier versions.

I've set up my workspaces with specific apps assigned to each (like B for browser, N for Notion, etc). The problem happens when I'm using Notion and try to switch to another workspace with a keyboard shortcut. While the workspace visually changes, Notion somehow stays focused - it still shows in the menu bar and the app in my new workspace doesn't get any keyboard input.

Weirdly, this only happens with Notion. Switching between other app workspaces works perfectly fine.

I did some digging and added debug logs to the code. It looks like when navigating away from the Notion workspace, the focusWindow method never gets called because AeroSpace thinks the window ID hasn't changed.

In this example, I switch from workspace 1 (Xcode) to workspace N (Notion) and then back to workspace 1. However, when I return to workspace 1, Notion remains the active application.

WorkspaceCommand.run() started with:
- args: workspace N
- env: CmdEnv(windowId: nil, workspaceName: nil, pwd: nil)
- io: AppBundle.CmdIo
- current focus: LiveFocus(windowOrNil: Optional(AppBundle.MacWindow), workspace: AppBundle.Workspace)
- previous focus: Optional(AppBundle.FrozenFocus(windowId: Optional(24427), workspaceName: "N", monitorId: 0))
- current workspace: 1
- current window: Optional(AppBundle.MacWindow)
- current monitor: MonitorImpl(monitorAppKitNsScreenScreensId: 1, name: "LG ULTRAFINE", rect: AppBundle.Rect(topLeftX: 0.0, topLeftY: 0.0, width: 1920.0, height: 1080.0), visibleRect: AppBundle.Rect(topLeftX: 0.0, topLeftY: 25.0, width: 1920.0, height: 1055.0))
- prev workspace: N
- prev window: 24427
WorkspaceCommand.run() resolved target: LiveFocus(windowOrNil: Optional(AppBundle.MacWindow), workspace: AppBundle.Workspace)
WorkspaceCommand.run() handling direct target 'N'
WorkspaceCommand.run() focusing workspace 'N'
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24447
updateFocusCache() window focus changed - attempting to focus window 24427
Window.focusWindow() called on:
- window: AppBundle.MacWindow
- windowId: 24427
- app: Notion
Window.focusWindow() attempting to focus window 24427 on workspace N
Window.focusWindow() focus result: true
updateFocusCache() focus result: true
updateFocusCache() updated lastKnownNativeFocusedWindowId to 24427
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)
WorkspaceCommand.run() started with:
- args: workspace 1
- env: CmdEnv(windowId: nil, workspaceName: nil, pwd: nil)
- io: AppBundle.CmdIo
- current focus: LiveFocus(windowOrNil: Optional(AppBundle.MacWindow), workspace: AppBundle.Workspace)
- previous focus: Optional(AppBundle.FrozenFocus(windowId: Optional(24447), workspaceName: "1", monitorId: 0))
- current workspace: N
- current window: Optional(AppBundle.MacWindow)
- current monitor: MonitorImpl(monitorAppKitNsScreenScreensId: 1, name: "LG ULTRAFINE", rect: AppBundle.Rect(topLeftX: 0.0, topLeftY: 0.0, width: 1920.0, height: 1080.0), visibleRect: AppBundle.Rect(topLeftX: 0.0, topLeftY: 25.0, width: 1920.0, height: 1055.0))
- prev workspace: 1
- prev window: 24447
WorkspaceCommand.run() resolved target: LiveFocus(windowOrNil: Optional(AppBundle.MacWindow), workspace: AppBundle.Workspace)
WorkspaceCommand.run() handling direct target '1'
WorkspaceCommand.run() focusing workspace '1'
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)
updateFocusCache() called with:
- nativeFocused: Optional(AppBundle.MacWindow)
- lastKnownNativeFocusedWindowId: 24427
updateFocusCache() no focus change needed (window IDs match)

Here's a link to the log statements I added: FelixLisczyk@274737d

I'm happy to help troubleshoot further if you can't reproduce it - just let me know what additional info would be useful or what parts of the code I should add more logging to.

Thanks for looking into this!

[nikitabobko]

#1292

[FelixLisczyk]

The issue still exists in the latest 0.18.2 beta. Occasionally it works, but most of the time, the Notion app keeps focus even after switching to another workspace.

[nikitabobko]

Thanks, reproduced. IDK yet what causing it. The tracking issue: #1325