Skip to content

Minor enhancements #92

Open
Open
@sajadhsm

Description

@sajadhsm

As I was reading through the source code, I've listed some minor issues which may improve the project:

  1. Route guards (Currently we can move to the login page by typing the address in the URL bar even when we are already logged in)
  2. mapValidationResponse does not handle 403 error
  3. No need to write <template #default> for suspense
  4. Enforce an import order convention
  5. Reset errors when re-submitting the forms
  6. useArticles composable:
    6.1. In fetchArticles function, since articleType can only have one value, it's better to use if-else rather than only if to skip other checks.
    6.2 getArticlesMeta function is acting like a composable. So maybe it's better to rename it to useArticlesMeta
  7. Vue docs doesn't recommend using generic argument for reactive(). So it may be better to change current generic usage.
  8. In AppLink component, useAttrs and v-bind="attrs" can be removed because of Fallthrough Attributes
  9. Add "Not Found" page

I would like to help fix these issues if they are valid to you. :D

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions