fix(test): close open connections (#1911)

* fix: tets hang up

* fix(test): close open connections

* test: catch error

* feat: move clean_method class to help

* fix: hang tests

* fix: lint style

* fix: teardown helper functionality

* docs: change examples according new changes

---------

Co-authored-by: Daniel Lando <[email protected]>

Author: MaximoLiberata

src/lib/client.ts

@@ -385,7 +385,10 @@ export type OnMessageCallback = (
 export type OnPacketCallback = (packet: Packet) => void
 export type OnCloseCallback = () => void
 export type OnErrorCallback = (error: Error | ErrorWithReasonCode) => void
-export type PacketCallback = (error?: Error, packet?: Packet) => any
+export type PacketCallback = (
+	error?: Error | ErrorWithReasonCode,
+	packet?: Packet,
+) => any
 export type CloseCallback = (error?: Error) => void
 
 export interface MqttClientEventCallbacks {

src/lib/handlers/ack.ts

@@ -1,6 +1,6 @@
 // Other Socket Errors: EADDRINUSE, ECONNRESET, ENOTFOUND, ETIMEDOUT.
 
-import { PacketHandler } from '../shared'
+import { PacketHandler, ErrorWithReasonCode } from '../shared'
 
 export const ReasonCodes = {
 	0: '',
@@ -82,8 +82,10 @@ const handleAck: PacketHandler = (client, packet) => {
 			const pubackRC = packet.reasonCode
 			// Callback - we're done
 			if (pubackRC && pubackRC > 0 && pubackRC !== 16) {
-				err = new Error(`Publish error: ${ReasonCodes[pubackRC]}`)
-				err.code = pubackRC
+				err = new ErrorWithReasonCode(
+					`Publish error: ${ReasonCodes[pubackRC]}`,
+					pubackRC,
+				)
 				client['_removeOutgoingAndStoreMessage'](messageId, () => {
 					cb(err, packet)
 				})
@@ -102,8 +104,10 @@ const handleAck: PacketHandler = (client, packet) => {
 			const pubrecRC = packet.reasonCode
 
 			if (pubrecRC && pubrecRC > 0 && pubrecRC !== 16) {
-				err = new Error(`Publish error: ${ReasonCodes[pubrecRC]}`)
-				err.code = pubrecRC
+				err = new ErrorWithReasonCode(
+					`Publish error: ${ReasonCodes[pubrecRC]}`,
+					pubrecRC,
+				)
 				client['_removeOutgoingAndStoreMessage'](messageId, () => {
 					cb(err, packet)
 				})