-
Notifications
You must be signed in to change notification settings - Fork 644
Add formatting rules #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here's the plan:
@thegedge - I can handle this to coordinate with the major version release, unless you want to get that sweet commit credit. |
💯 I have no strong opinions either (I have my preferences, of course!), but agreed that it just needs to be automatic to not waste anyone's time. Prettier is of course the go-to tool these days, but I know not everyone is behind its prescriptiveness. I'm not as deep into the ecosystem, so perhaps you have some other suggestions, @coolsoftwaretyler? If not, I say we use prettier and call it a day. My recommendations:
[EDIT] |
Actually, ignore my recommendations. I think we should respect the choices of the organization, which is in disagreement with (1) but not (2). Let's just copy the prettier settings from https://github.com/mobxjs/mobx |
Great find, I agree! |
Alrighty, v7.0.0 is out, so I'll tackle this sometime soon. |
Just a small issue to capture this comment: we need to add auto-formatting to this repository so that all PRs are consistent and to reduce some of the noisy formatting diffs we tend to get.
The text was updated successfully, but these errors were encountered: