Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Commit dae9e3d

Browse files
authored
chore(dev-deps): Clean up deps listings in build.gradle (#44)
#### Description of changes This cleans up some outdated bits of build.gradle's `dependencies` block: * Removes obsolete commented dependency * Updates `androidTestImplementation` to use the more current `androidx` version rather than the deprecated `com.android.support` equivalent (this has the side effect of updating the lockfile to use stable rather than alpha versions of some testing libraries) * Clarifies dev vs non-dev dependencies * Sort lines #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [n/a] Added/updated relevant unit test(s) - [x] Ran `./gradlew fastpass` from `AccessibilityInsightsForAndroidService` - [x] PR title _AND_ final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`).
1 parent 1129e6b commit dae9e3d

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

AccessibilityInsightsForAndroidService/app/build.gradle

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,21 @@ android {
3838
}
3939

4040
dependencies {
41-
implementation fileTree(dir: 'libs', include: ['*.jar'])
42-
androidTestImplementation('com.android.support.test.espresso:espresso-core:3.0.2', {
43-
exclude group: 'com.android.support', module: 'support-annotations'
44-
})
45-
// implementation 'com.android.support:appcompat-v7:28.0.0'
46-
implementation 'com.google.code.gson:gson:2.8.6'
41+
// Non-dev dependencies (redistributed with releases)
4742
implementation 'androidx.annotation:annotation:1.1.0'
43+
implementation 'com.deque.android:axe-android:0.2.0'
44+
implementation 'com.google.code.gson:gson:2.8.6'
45+
46+
// Dev dependencies (not redistributed)
47+
androidTestImplementation('androidx.test.espresso:espresso-core:3.1.0')
48+
lintClassPath 'org.apache.commons:commons-compress:1.20'
49+
lintClassPath 'org.bouncycastle:bcpkix-jdk15on:1.66'
50+
lintClassPath 'org.bouncycastle:bcprov-jdk15on:1.66'
4851
testImplementation 'junit:junit:4.13'
4952
testImplementation 'org.mockito:mockito-core:3.5.9'
53+
testImplementation 'org.powermock:powermock-api-mockito2:2.0.7'
5054
testImplementation 'org.powermock:powermock-core:2.0.7'
5155
testImplementation 'org.powermock:powermock-module-junit4:2.0.7'
52-
testImplementation 'org.powermock:powermock-api-mockito2:2.0.7'
53-
lintClassPath 'org.bouncycastle:bcpkix-jdk15on:1.66'
54-
lintClassPath 'org.bouncycastle:bcprov-jdk15on:1.66'
55-
lintClassPath 'org.apache.commons:commons-compress:1.20'
56-
implementation 'com.deque.android:axe-android:0.2.0'
5756
}
5857

5958
configurations.all {

AccessibilityInsightsForAndroidService/app/gradle.lockfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
# Manual edits can break the build and are not advised.
33
# This file is expected to be part of source control.
44
androidx.annotation:annotation:1.1.0=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath,debugCompileClasspath,debugRuntimeClasspath,debugUnitTestCompileClasspath,debugUnitTestRuntimeClasspath,releaseCompileClasspath,releaseRuntimeClasspath,releaseUnitTestCompileClasspath,releaseUnitTestRuntimeClasspath
5-
androidx.test.espresso:espresso-core:3.1.0-alpha3=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
6-
androidx.test.espresso:espresso-idling-resource:3.1.0-alpha3=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
7-
androidx.test:monitor:1.1.0-alpha3=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
8-
androidx.test:runner:1.1.0-alpha3=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
5+
androidx.test.espresso:espresso-core:3.1.0=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
6+
androidx.test.espresso:espresso-idling-resource:3.1.0=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
7+
androidx.test:monitor:1.1.0=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
8+
androidx.test:runner:1.1.0=debugAndroidTestCompileClasspath,debugAndroidTestRuntimeClasspath
99
com.android.tools.analytics-library:protos:27.0.1=lintClassPath
1010
com.android.tools.analytics-library:shared:27.0.1=lintClassPath
1111
com.android.tools.analytics-library:tracker:27.0.1=lintClassPath

0 commit comments

Comments
 (0)