-
-
Notifications
You must be signed in to change notification settings - Fork 13
Expand api coverage #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…/log/percentiles, etc)
CI seems to be failing badly. Would you mind taking a look? Also, we would need to drop the current mechanism for doing prebuilts, as it does not make any sense anymore with n-api. |
We should switch to https://www.npmjs.com/package/prebuild-install for prebuilts. |
Or |
definitely prebuildify!
I would also take the time to move to github actions - the windows support is better.
Il 28 nov 2019, 08:13 +0000, Vincent Weevers <[email protected]>, ha scritto:
… Or prebuildify
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Oh, could you expand on that? What's better? |
It’s faster and more reliable than AppVeyor.
Il 28 nov 2019, 08:24 +0000, Vincent Weevers <[email protected]>, ha scritto:
… > I would also take the time to move to github actions - the windows support is better
Oh, could you expand on that? What's better?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I do not know AppVeyor to be unreliable - at all - but I'll take that it's faster. To be fair, when more people move to GitHub actions, queue times will undoubtedly increase. |
I don't have a windows box but I'll see if I can find a VM i can use. |
Major update in
api
coverage. in addition,nan
was replaced withn-api
.Each new feature is accompanied by tests and docs.
This is my first non-academic
c++
project, so there are probably a few things that can be done more idiomatically.