Skip to content

Expand api coverage #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

ccollie
Copy link
Contributor

@ccollie ccollie commented Nov 26, 2019

Major update in api coverage. in addition, nan was replaced with n-api.
Each new feature is accompanied by tests and docs.

This is my first non-academic c++ project, so there are probably a few things that can be done more idiomatically.

@mcollina
Copy link
Owner

CI seems to be failing badly. Would you mind taking a look?

Also, we would need to drop the current mechanism for doing prebuilts, as it does not make any sense anymore with n-api.

@mcollina
Copy link
Owner

We should switch to https://www.npmjs.com/package/prebuild-install for prebuilts.

@vweevers
Copy link
Collaborator

Or prebuildify

@mcollina
Copy link
Owner

mcollina commented Nov 28, 2019 via email

@vweevers
Copy link
Collaborator

I would also take the time to move to github actions - the windows support is better

Oh, could you expand on that? What's better?

@mcollina
Copy link
Owner

mcollina commented Nov 28, 2019 via email

@vweevers
Copy link
Collaborator

I do not know AppVeyor to be unreliable - at all - but I'll take that it's faster. To be fair, when more people move to GitHub actions, queue times will undoubtedly increase.

@ccollie
Copy link
Contributor Author

ccollie commented Nov 28, 2019

I don't have a windows box but I'll see if I can find a VM i can use.

@jschlight jschlight mentioned this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants