LUT-26831: simplify get response from backup

Author: TimotheeHrl

src/java/fr/paris/lutece/plugins/forms/service/FormService.java

@@ -439,16 +439,21 @@ private boolean canUserAccessFile( HttpServletRequest request, int nIdForm )
      *            The form
      * @param strUserGuid
      *            The user guid
+     * @param formResponseManager
+     *
      * @return the created {@code FormResponseManager} object
      */
-    public FormResponseManager createFormResponseManagerFromBackUp( Form form, String strUserGuid )
+    public FormResponseManager createFormResponseManagerFromBackUp( Form form, String strUserGuid, FormResponseManager formResponseManager )
     {
-        FormResponseManager formResponseManager = null;
         List<FormResponse> listFormResponse = FormResponseHome.getFormResponseByGuidAndForm( strUserGuid, form.getId( ), true );
         if ( CollectionUtils.isNotEmpty( listFormResponse ) )
         {
             formResponseManager = new FormResponseManager( listFormResponse.get( 0 ) );
         }
+        else if ( formResponseManager != null &&  CollectionUtils.isEmpty( listFormResponse ) )
+        {
+            return formResponseManager;
+        }
         else
         {
             formResponseManager = new FormResponseManager( form );

src/java/fr/paris/lutece/plugins/forms/web/FormXPage.java

@@ -884,6 +884,12 @@ public synchronized XPage doSaveStep( HttpServletRequest request ) throws SiteMe
             _currentStep = StepHome.findByPrimaryKey(Integer.parseInt(request.getParameter(FormsConstants.PARAMETER_ID_STEP)));
             List<String> errorList = new ArrayList<>( );
             _currentStep = FormsResponseUtils.getNextStep( _currentStep.getId( ), errorList, _formResponseManager );
+            // print all parameters
+            Enumeration<String> parameterNames = request.getParameterNames();
+            while (parameterNames.hasMoreElements()) {
+                String paramName = parameterNames.nextElement();
+                AppLogService.error("########### : " + paramName + " : " + request.getParameter(paramName));
+            }
             return getStepView(  request );
         }
 
@@ -1245,7 +1251,7 @@ private void initFormResponseManager( HttpServletRequest request, Form form )
         {
             if ( user != null  && form.isBackupEnabled() )
             {
-                _formResponseManager = _formService.createFormResponseManagerFromBackUp( form, user.getName( ) );
+                _formResponseManager = _formService.createFormResponseManagerFromBackUp( form, user.getName( ), _formResponseManager );
             }
             else
             {
@@ -1302,7 +1308,6 @@ private void init( HttpServletRequest request )
         _stepDisplayTree = null;
         _breadcrumb = null;
         _bInactiveStateBypassed = false;
-        IsRequestComingFromAction = false;
         FormsAsynchronousUploadHandler.getHandler( ).removeSessionFiles( request.getSession( ) );
     }