Skip to content

bug: The published builds on Docker Hub for spacebin are purely for arm64 platform #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tuxdude opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
💥 bug Something isn't working
Milestone

Comments

@Tuxdude
Copy link

Tuxdude commented Sep 5, 2024

What happened?

The published builds on Docker Hub for spacebin are purely for arm64 platform. Better to use multi platform images that support both amd64 and arm64 platforms.

Minimum steps to reproduce

N/A

Version

Any

What browsers are you seeing the problem on?

No response

Relevant log output

No response

@Tuxdude Tuxdude added the 💥 bug Something isn't working label Sep 5, 2024
@lukewhrit lukewhrit self-assigned this Sep 5, 2024
@lukewhrit lukewhrit moved this to ✈️ In Progress in Spacebin Sep 5, 2024
@lukewhrit lukewhrit added this to the v1.1.0 milestone Sep 5, 2024
@lukewhrit
Copy link
Owner

lukewhrit commented Sep 6, 2024

Latest images pushed are amd64. I've just fixed the Github action that automatically creates Docker images on release so I think we will just end up doing only amd64 images from now on, since I no longer have to build on my M1 laptop.

Also now available on Github Container Registry - https://ghcr.io/lukewhrit/spacebin

@github-project-automation github-project-automation bot moved this from 🐛 Bugs / QOL to 💎 Done in Spacebin Sep 6, 2024
@duckfullstop
Copy link

duckfullstop commented Jan 2, 2025

Is there a case for re-opening this? I'd say building purely for amd64 is becoming less tenable with the upsurge in hosted arm64 platforms.

Should be pretty straightforward to use an Actions matrix or similar to build both - perhaps one of my workflows might be useful to you for inspiration?

@lukewhrit
Copy link
Owner

Is there a case for re-opening this? I'd say building purely for amd64 is becoming less tenable with the upsurge in hosted arm64 platforms.

Should be pretty straightforward to use an Actions matrix or similar to build both - perhaps one of my workflows might be useful to you for inspiration?

Yeah, sure. You're definitely right about more arm64 systems so we can definitely add back builds to Docker. I'll reopen this and try to get it implement sooner rather than later but I'm pretty busy and Spacebin hasn't been a priority.

@lukewhrit lukewhrit reopened this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 bug Something isn't working
Projects
Status: 💎 Done
Development

No branches or pull requests

3 participants