Skip to content

Datasource Generator do not accept cli option "--connector" #9607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thiscode opened this issue Jun 3, 2023 · 0 comments · Fixed by #9608
Closed

Datasource Generator do not accept cli option "--connector" #9607

thiscode opened this issue Jun 3, 2023 · 0 comments · Fixed by #9608
Labels
bug

Comments

@thiscode
Copy link
Contributor

thiscode commented Jun 3, 2023

Describe the bug

The documentation says that you can call the loopback cli datasource generator with the --connector option. However, this option has no effect. Despite the specification, the connector type is asked.

Logs

No response

Additional information

The main generator code uses this.artifactInfo to determine the passed value connector. However, this object does not have this value. This can be found in this.options. I transferred the value to the correct place in the setOptions method.

Reproduction

https://github.com/loopbackio/loopback-next
@thiscode thiscode added the bug label Jun 3, 2023
thiscode added a commit to thiscode/loopback-next that referenced this issue Jun 3, 2023
@thiscode
fix(packages/cli/generators/datasource): fix the usage of the option …
e530013 
…--connector

fix loopbackio#9607

Signed-off-by: Thomas Miliopoulos <[email protected]>
@thiscode thiscode mentioned this issue Jun 3, 2023
Merged
8 tasks
thiscode added a commit to thiscode/loopback-next that referenced this issue Jun 3, 2023
@thiscode
fix: fix the usage of the option --connector
043bf9e 
fix loopbackio#9607

Signed-off-by: Thomas Miliopoulos <[email protected]>
dhmlau pushed a commit that referenced this issue Jun 18, 2023
@thiscode @dhmlau
fix: fix the usage of the option --connector
5ed00ea 
fix #9607

Signed-off-by: Thomas Miliopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix the usage of the option "connector" thiscode/loopback-next
1 participant
@thiscode