Merge pull request #853 from libgit2/cmn/parse-commit-return

carlosmn · web-flow · commit d928ca68fe76 · 2020-08-21T13:08:23.000+02:00
commit: parse_commit_options returns an int
diff --git a/ext/rugged/rugged_commit.c b/ext/rugged/rugged_commit.c
@@ -425,7 +425,7 @@ struct commit_data {
  * Note that parents may be set even when the function errors, so make
  * sure to free this data.
  */
-static VALUE parse_commit_options(struct commit_data *out, git_repository *repo, VALUE rb_data)
+static int parse_commit_options(struct commit_data *out, git_repository *repo, VALUE rb_data)
 {
 	VALUE rb_message, rb_tree, rb_parents, rb_ref;
 	int error = 0, parent_count, i;

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,7 @@ struct commit_data {`
`425`	`425`	`* Note that parents may be set even when the function errors, so make`
`426`	`426`	`* sure to free this data.`
`427`	`427`	`*/`
`428`		`-static VALUE parse_commit_options(struct commit_data out, git_repository repo, VALUE rb_data)`
	`428`	`+static int parse_commit_options(struct commit_data out, git_repository repo, VALUE rb_data)`
`429`	`429`	`{`
`430`	`430`	`VALUE rb_message, rb_tree, rb_parents, rb_ref;`
`431`	`431`	`int error = 0, parent_count, i;`