We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
upsert
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Based on the source code, current langchain_milvus.Milvus.upsert methods delete the chunks with the proper ids from the collection and then insert the chunks provided in the method: https://github.com/langchain-ai/langchain-milvus/blob/main/libs/milvus/langchain_milvus/vectorstores/milvus.py#L1993-#L2024
langchain_milvus.Milvus.upsert
However, since the last few Milvus versions, there is a native upsert method for MilvusClient: https://milvus.io/api-reference/pymilvus/v2.5.x/MilvusClient/Vector/upsert.md Using the dedicated method for the upsert process, may be a more efficient approach and will definitely reduce the code complexity.
MilvusClient
Shouldn't the langchain_milvus.Milvus use the mative upsert method under the hood?
langchain_milvus.Milvus
The text was updated successfully, but these errors were encountered:
@Mateusz-Switala thanks, you are right, we will update it within few days
Sorry, something went wrong.
use milvus naive upsert function (#79)
9bf1667
as mentioned here #71 Signed-off-by: ChengZi <[email protected]>
fixed
No branches or pull requests
Based on the source code, current
langchain_milvus.Milvus.upsert
methods delete the chunks with the proper ids from the collection and then insert the chunks provided in the method: https://github.com/langchain-ai/langchain-milvus/blob/main/libs/milvus/langchain_milvus/vectorstores/milvus.py#L1993-#L2024However, since the last few Milvus versions, there is a native
upsert
method forMilvusClient
: https://milvus.io/api-reference/pymilvus/v2.5.x/MilvusClient/Vector/upsert.md Using the dedicated method for the upsert process, may be a more efficient approach and will definitely reduce the code complexity.Shouldn't the
langchain_milvus.Milvus
use the mative upsert method under the hood?The text was updated successfully, but these errors were encountered: