Skip to content

[langchain-sqlserver] Add support for upserting documents #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yorek opened this issue Dec 2, 2024 · 0 comments
Open

[langchain-sqlserver] Add support for upserting documents #13

yorek opened this issue Dec 2, 2024 · 0 comments
Labels
P2 P2 Priority items sql-server Issues related to langchain-sqlserver

Comments

@yorek
Copy link
Collaborator

yorek commented Dec 2, 2024

When using add_texts or add_documents or from_documents, it should be possible to have an option named upsert that, if set to true will

  • insert a new row in the underlying table if a row with the same id doesn't exists or,
  • update an existing row with the new data, if a row with the same id is existing already

The id used to check if a row is existing or not is the id provided by the developer, currently saved in the custom_id column, By default upsert will be set to false to keep consistency with other vector stores.

@yorek yorek added sql-server Issues related to langchain-sqlserver P2 P2 Priority items labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 P2 Priority items sql-server Issues related to langchain-sqlserver
Projects
None yet
Development

No branches or pull requests

1 participant