Skip to content

Commit 30be692

Browse files
committed
CHANGELOG.md: Add changes for trigger refactoring
1 parent bfcf80a commit 30be692

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

CHANGELOG.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@
1212
- Bugfix: `trigger.unit` and `trigger.every` (String) could fail in different user locales. The value of those two properties was upper cased by [String.toUpperCase()](https://developer.android.com/reference/java/lang/String#toUpperCase()) and turned after into an `Enum`. The method `String.toUpperCase()` is locale aware and will use the current user locale to upper case the string. In Turkish, for e.g., the value `minute` would become upper cased to `MİNUTE` where the I has a dot above it and would not recognized as an Enum. Now enums will not be used anymore and the values are taken as they come from JavaScript and are expected to be lower cased like `minute`, `hour` etc.
1313
- Thanks [TheNotorius0](https://github.com/TheNotorius0) for sharing his experiences in issue [2060](https://github.com/katzer/cordova-plugin-local-notifications/issues/2060) as a [comment](https://github.com/katzer/cordova-plugin-local-notifications/issues/2060#issuecomment-2751895663) and also [pahenator](https://github.com/pahenator) for initially posting the issue.
1414
- Thanks [iamAdamGoodman](https://github.com/iamAdamGoodman) noting that `trigger.at` was not functioning after adding these changes in issue [2070](https://github.com/katzer/cordova-plugin-local-notifications/issues/2070)
15+
- Throw exception if the `trigger` property is set wrong
1516
- Code refactoring
16-
- Renamed `DateTrigger.java` to `OptionsTrigger.java`
17-
- All `trigger` propertiers are handled by `OptionsTrigger`
18-
- `Options` class instantiates the right trigger class for the `trigger` property instead of the `Notification` class
17+
- Renamed `DateTrigger.java` to `TriggerHandler.java`
18+
- Added `OptionsTrigger` which is a helper to read the trigger properties
19+
- Split `IntervalTrigger` in `TriggerHandlerAt`, `TriggerHandlerIn` and `TriggerHandlerEvery`, to better refelect the trigger options
20+
- Rename `MatchTrigger` to `TriggerHandlerEvery`
1921
- Remove `BuilderCreator` and move code to `Notification`
2022
- Move notification show code from `TriggerReceiver` to `Notification`
2123

0 commit comments

Comments
 (0)