Skip to content

feat(dynamic_routing): add open router integration for elimination routing #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

feat(dynamic_routing): add open router integration for elimination routing #7896

merged 4 commits into from
Apr 29, 2025
+121 −56

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Apr 24, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds the elimination routing integration support with open router.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create merchant_account, api_key, mca

  1. Enable elimination routing for merchant
curl --location --request POST 'http://localhost:8080/account/merchant_1744368166/business_profile/pro_GrzjTHd5Pn5hAhwTZPRn/dynamic_routing/elimination/toggle?enable=dynamic_connector_selection' \
--header 'api-key: xyz'
  1. Enable Volume split
curl --location --request POST 'http://localhost:8080/account/merchant_1744368166/business_profile/pro_GrzjTHd5Pn5hAhwTZPRn/dynamic_routing/set_volume_split?split=100' \
--header 'api-key: xyz'
  1. Create a Payment
    Search for the log " penalizing the elimination score of the gateway with id"
    image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

Sorry, something went wrong.

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-routing Area: Routing labels Apr 24, 2025
@Chethan-rao Chethan-rao self-assigned this Apr 24, 2025
@Chethan-rao Chethan-rao requested review from a team as code owners April 24, 2025 13:32
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Apr 24, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/routing/transformers.rs  31% smaller
  crates/router/src/core/payments/routing.rs  26% smaller
  crates/router/src/core/routing/helpers.rs  7% smaller
  crates/api_models/src/open_router.rs  0% smaller
  crates/api_models/src/routing.rs  0% smaller

@Chethan-rao Chethan-rao linked an issue Apr 24, 2025 that may be closed by this pull request
open router integration of elimination routing #7895
Closed
@Chethan-rao Chethan-rao force-pushed the er_integration_decion_engine branch 4 times, most recently from 87a15cb to 54e92e2 Compare April 24, 2025 13:52
@Chethan-rao
feat(dynamic_routing): add open router integration for elimination ro…

Verified

This commit was signed with the committer’s verified signature.
Chethan-rao Chethan Rao
SSH Key Fingerprint: os132C9AaCt6WWaYKxxFXL8L88cyVYEogpzBrIg/HgQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
15e4447 
…uting
@Chethan-rao Chethan-rao force-pushed the er_integration_decion_engine branch from 54e92e2 to 15e4447 Compare April 24, 2025 16:02
@Chethan-rao
address requested changes

Verified

This commit was signed with the committer’s verified signature.
Chethan-rao Chethan Rao
SSH Key Fingerprint: os132C9AaCt6WWaYKxxFXL8L88cyVYEogpzBrIg/HgQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
ecb431f
@Chethan-rao Chethan-rao force-pushed the er_integration_decion_engine branch from 634b1f2 to ecb431f Compare April 25, 2025 06:42
ShankarSinghC
ShankarSinghC previously approved these changes Apr 25, 2025
View reviewed changes
@Chethan-rao
add ForeignFrom for AttemptStatus

Verified

This commit was signed with the committer’s verified signature.
Chethan-rao Chethan Rao
SSH Key Fingerprint: os132C9AaCt6WWaYKxxFXL8L88cyVYEogpzBrIg/HgQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
40e6e85
@Chethan-rao Chethan-rao requested a review from Sarthak1799 April 25, 2025 09:33
@Chethan-rao
Merge branch 'main' into er_integration_decion_engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2b2f59c
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit 4745ce9 Apr 29, 2025
16 of 20 checks passed
@likhinbopanna likhinbopanna deleted the er_integration_decion_engine branch April 29, 2025 09:51
@hyperswitch-bot hyperswitch-bot bot removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagan-jaya jagan-jaya

@prajjwalkumar17 prajjwalkumar17

@Sarthak1799 Sarthak1799

@ShankarSinghC ShankarSinghC

Assignees

@Chethan-rao Chethan-rao

Labels
A-routing Area: Routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open router integration of elimination routing
6 participants
@Chethan-rao @jagan-jaya @prajjwalkumar17 @Sarthak1799 @ShankarSinghC @likhinbopanna