Completer shows up on every keystroke, not only on trigger characters #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

krassowski opened this issue Mar 19, 2025 · 0 comments · May be fixed by #1117

Member

krassowski commented Mar 19, 2025

Description

With continuous hinting off completer still shows up on every keystroke. This is because of faulty logic in:

jupyterlab-lsp/packages/jupyterlab-lsp/src/features/completion/provider.ts

Lines 190 to 196 in b2eb9b1

    
             return sourceChange.some( 
        
               delta => 
        
                 delta.insert != null && 
        
                 (triggerCharacters.includes(delta.insert) || 
        
                   (!completerIsVisible && delta.insert.trim().length > 0)) 
        
             ); 
        
           }

krassowski linked a pull request

that will close this issue

Fix completer heuristics #1117

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment