Skip to content

Commit 352072d

Browse files
jthegeduspham
andauthored
fix!: sync with [email protected] based on (PRs #194 #200) (#203)
* chore: bump asdf tools * chore: bump dependencies * chore: apply xojs fixes * test: bump test functions to nodejs18 * test: bump test deps & devdeps * fix: rm check of runtime version assume nodejs18 * docs: update compat table * test: fix end-to-end test firebase config * chore(deps): Bump kit v1.1.1; ava, xo, esbuild, firebase-functions * fix(lint): Use explicit `import type` statement * fix(lint): Use the preferred nullish coalescing op over ternary * test(version): Switch to `checkout@v3` to get rid of Node.js 12 warnings * feat: Add Node.js 18 support * fix: Missing 2nd argument for (reading 'prerendering' error) * fix(#200/@AndrewLester): Write prerendered fiels to public directory * test(version): Add Node.js 18 to test cases * fix(test): Add static route for `/about`. Switch from Svelte demo -> sverdle * fix(test): Missing quote in `firebase.json`. Change label in test from Todos to Sverdle Co-authored-by: Paul Pham <[email protected]>
1 parent a4b4daa commit 352072d

File tree

17 files changed

+1253
-1524
lines changed

17 files changed

+1253
-1524
lines changed

.github/workflows/test.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
unit:
1515
runs-on: ubuntu-latest
1616
steps:
17-
- uses: actions/checkout@v2
17+
- uses: actions/checkout@v3
1818
- name: install asdf
1919
uses: asdf-vm/actions/install@v1
2020
- run: pnpm install
@@ -47,7 +47,7 @@ jobs:
4747
nested_dir: ".",
4848
}
4949
steps:
50-
- uses: actions/checkout@v2
50+
- uses: actions/checkout@v3
5151
- name: install asdf
5252
uses: asdf-vm/actions/install@v1
5353
- name: Run Integration test for ${{ matrix.params.test_dir }}
@@ -59,7 +59,7 @@ jobs:
5959
needs:
6060
- unit
6161
steps:
62-
- uses: actions/checkout@v2
62+
- uses: actions/checkout@v3
6363
- name: install asdf
6464
uses: asdf-vm/actions/install@v1
6565
- name: Cache firebase emulators

.tool-versions

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
firebase 11.6.0
2-
nodejs 16.16.0
3-
pnpm 7.9.1
1+
firebase 11.18.0
2+
nodejs 18.12.1
3+
pnpm 7.18.2
44

55
# use for Firebase Emulator
66

README.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,21 @@ Cloud Functions!
3636

3737
## Contents
3838

39+
- [Contents](#contents)
3940
- [Setup](#setup)
4041
- [Beta Adapter Version Compatibility](#beta-adapter-version-compatibility)
4142
- [Configuration Overview](#configuration-overview)
4243
- [Details](#details)
4344
- [`firebase.json` Configurations](#firebasejson-configurations)
4445
- [Adapter Configurations](#adapter-configurations)
4546
- [How it works](#how-it-works)
46-
- [Firebase Emulator local Testing](#cloud-function-firebase-emulator-local-testing)
47+
- [Firebase Emulator local Testing](#firebase-emulator-local-testing)
4748
- [Deployment](#deployment)
4849
- [Caveats](#caveats)
49-
- [Non-Goals](#non-goals)
50+
- [Non-goals](#non-goals)
5051
- [FAQ](#faq)
5152
- [Contributing](#contributing)
53+
- [external contributions](#external-contributions)
5254

5355
## Setup
5456

@@ -86,6 +88,7 @@ the Adapter and SvelteKit becoming incompatible. Here is a compatibility table:
8688

8789
| Adapter Version | SvelteKit Version |
8890
| --------------- | -------------------- |
91+
| `0.14.5` | `1.0.0-next.587` |
8992
| `0.14.4` | `1.0.0-next.443` |
9093
| `0.14.3` | `1.0.0-next.443` |
9194
| `0.14.2` | `1.0.0-next.405` |
@@ -531,7 +534,7 @@ import/require of the generated code will not change unless you change the
531534
`firebase.json:hosting.site` or `package.json:main` fields, so you shouldn't
532535
need to update this code after adding it.
533536

534-
## Cloud Function Firebase Emulator local Testing
537+
## Firebase Emulator local Testing
535538

536539
Test your production build locally before pushing to git or deploying!
537540

package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,18 @@
3838
"node": "^14.13.1 || >= 16"
3939
},
4040
"dependencies": {
41-
"esbuild": "^0.15.2"
41+
"esbuild": "^0.17.0"
4242
},
4343
"peerDependencies": {
44-
"@sveltejs/kit": "^1.0.0-next.443"
44+
"@sveltejs/kit": "^1.0.0-next.587"
4545
},
4646
"devDependencies": {
47-
"@sveltejs/kit": "^1.0.0-next.443",
47+
"@sveltejs/kit": "^1.1.1",
4848
"@types/express": "^4.17.13",
4949
"@types/node": "^18.7.3",
50-
"ava": "^4.3.1",
51-
"firebase-functions": "^3.22.0",
52-
"xo": "^0.51.0"
50+
"ava": "^5.1.1",
51+
"firebase-functions": "^4.1.1",
52+
"xo": "^0.53.1"
5353
},
5454
"scripts": {
5555
"fix": "xo --fix",

0 commit comments

Comments
 (0)