Skip to content

Can you make the style import seperate? #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majodu opened this issue May 17, 2024 · 5 comments
Open

Can you make the style import seperate? #53

majodu opened this issue May 17, 2024 · 5 comments

Comments

@majodu
Copy link

majodu commented May 17, 2024

Its kind of a pain to override some of the styles.

Is it possible to have the CSS separate from the code?

Copy link

Thank you for taking the time to submit an Issue!
You should get a response to this issue within one to two days.

@majodu
Copy link
Author

majodu commented May 19, 2024

Similar to when you import bootstrap styles import 'bootstrap/dist/css/bootstrap.css';

@jonmbake
Copy link
Owner

The terminal styling is currently imported: https://github.com/jonmbake/react-terminal-ui/blob/master/src/index.tsx#L4. Currently there is not a great way to override the style that was imported. In order to allow style overrides, I think we'd have to add a prop like:

terminalStyle?: React.CSSProperties;

@majodu
Copy link
Author

majodu commented May 21, 2024

A simple way would just have the imports separately. You could import the package, and then import the css. This way you import the default styles and then put your own styles underneath to override them.

@jonmbake
Copy link
Owner

Hi @majodu. Feel to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants