Bump org.jenkins-ci.plugins:plugin from 5.7 to 5.9 (#291)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: dependabot[bot]

pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>org.jenkins-ci.plugins</groupId>
         <artifactId>plugin</artifactId>
-        <version>5.7</version>
+        <version>5.9</version>
         <relativePath />
     </parent>
 

src/main/java/org/jenkinsci/plugins/GithubAuthenticationToken.java

@@ -30,7 +30,6 @@ of this software and associated documentation files (the "Software"), to deal
 import com.github.benmanes.caffeine.cache.Caffeine;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.model.Item;
 import hudson.security.Permission;
 import hudson.security.SecurityRealm;
@@ -183,12 +182,10 @@ public boolean isPrivate() {
         }
     }
 
-    @SuppressFBWarnings(value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     public GithubAuthenticationToken(final String accessToken, final String githubServer) throws IOException {
         this(accessToken, githubServer, false);
     }
 
-    @SuppressFBWarnings(value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     public GithubAuthenticationToken(final String accessToken, final String githubServer, final boolean clearUserCache) throws IOException {
         super(List.of());
 
@@ -374,7 +371,6 @@ public GHMyself getMyself() throws IOException {
      * @return                    the Set of org names current user is a member of
      */
     @NonNull
-    @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     private Set<String> getUserOrgs() {
         return userOrganizationCache.get(this.userName, unused -> {
             try {
@@ -439,7 +435,6 @@ private boolean isReadRelatedPermission(@NonNull Permission permission) {
      * @return [description]
      */
     @NonNull
-    @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     private Cache<String, RepoRights> myRepositories() {
             return repositoriesByUserCache.get(this.userName, unused -> {
                         // listRepositories returns all repos owned by user, where they are a collaborator,
@@ -519,7 +514,6 @@ GHOrganization loadOrganization(@NonNull String organization) {
     }
 
     @NonNull
-    @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     private RepoRights loadRepository(@NonNull final String repositoryName) {
       try {
           if (gh != null && isAuthenticated() && (myRealm.hasScope("repo") || myRealm.hasScope("public_repo"))) {

src/main/java/org/jenkinsci/plugins/GithubOAuthUserDetails.java

@@ -4,7 +4,6 @@
 package org.jenkinsci.plugins;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.Collection;
 import org.springframework.security.core.GrantedAuthority;
 import org.springframework.security.core.userdetails.User;
@@ -14,7 +13,6 @@
  * @author Mike
  *
  */
-@SuppressFBWarnings("EQ_DOESNT_OVERRIDE_EQUALS")
 public class GithubOAuthUserDetails extends User implements UserDetails {
 
     private static final long serialVersionUID = 1L;