Refactoring

Author: ivanpaulovich

.gitignore

@@ -328,3 +328,4 @@ ASALocalRun/
 
 # MFractors (Xamarin productivity tool) working folder 
 .mfractor/
+.vscode/

src/Finance.Domain/Accounts/Account.cs

@@ -4,7 +4,7 @@
     using System;
     using System.Collections.ObjectModel;
 
-    public class Account : IEntity, IAggregateRoot
+    public sealed class Account : IEntity, IAggregateRoot
     {
         public Guid Id { get; }
         public Guid CustomerId { get; }
@@ -19,6 +19,13 @@ public ReadOnlyCollection<ITransaction> Transactions
 
         private TransactionCollection _transactions;
 
+        public Account(Guid id, Guid customerId, TransactionCollection transactions)
+        {
+            Id = id;
+            _transactions = transactions;
+            CustomerId = customerId;
+        }
+
         public Account(Guid customerId)
         {
             Id = Guid.NewGuid();
@@ -52,5 +59,11 @@ public Amount GetCurrentBalance()
             Amount totalAmount = _transactions.GetCurrentBalance();
             return totalAmount;
         }
+
+        public ITransaction GetLastTransaction()
+        {
+            ITransaction transaction = _transactions.GetLastTransaction();
+            return transaction;
+        }
     }
 }

src/Finance.Domain/Accounts/AccountCannotBeClosedException.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain.Accounts
 {
-    public class AccountCannotBeClosedException : DomainException
+    public sealed class AccountCannotBeClosedException : DomainException
     {
         internal AccountCannotBeClosedException(string message)
             : base(message)

src/Finance.Domain/Accounts/Credit.cs

@@ -3,7 +3,7 @@
     using Finance.Domain.ValueObjects;
     using System;
 
-    public class Credit : IEntity, ITransaction
+    public sealed class Credit : IEntity, ITransaction
     {
         public Guid Id { get; }
         public Guid AccountId { get; }
@@ -12,19 +12,22 @@ public string Description
         {
             get { return "Credit"; }
         }
+        public DateTime TransactionDate { get; }
 
-        public Credit(Guid id, Guid accountId, Amount amount)
+        public Credit(Guid id, Guid accountId, Amount amount, DateTime transactionDate)
         {
             Id = id;
             AccountId = accountId;
             Amount = amount;
+            TransactionDate = transactionDate;
         }
 
         public Credit(Guid accountId, Amount amount)
         {
             Id = Guid.NewGuid();
             AccountId = accountId;
             Amount = amount;
+            TransactionDate = DateTime.UtcNow;
         }
     }
 }

src/Finance.Domain/Accounts/Debit.cs

@@ -3,7 +3,7 @@
     using Finance.Domain.ValueObjects;
     using System;
 
-    public class Debit : IEntity, ITransaction
+    public sealed class Debit : IEntity, ITransaction
     {
         public Guid Id { get; }
         public Guid AccountId { get; }
@@ -12,19 +12,22 @@ public string Description
         {
             get { return "Debit"; }
         }
+        public DateTime TransactionDate { get; }
 
-        public Debit(Guid id, Guid accountId, Amount amount)
+        public Debit(Guid id, Guid accountId, Amount amount, DateTime transactionDate)
         {
             Id = id;
             AccountId = accountId;
             Amount = amount;
+            TransactionDate = transactionDate;
         }
 
         public Debit(Guid accountId, Amount amount)
         {
             Id = Guid.NewGuid();
             AccountId = accountId;
             Amount = amount;
+            TransactionDate = DateTime.UtcNow;
         }
     }
 }

src/Finance.Domain/Accounts/ITransaction.cs

@@ -1,10 +1,12 @@
 namespace Finance.Domain.Accounts
 {
     using Finance.Domain.ValueObjects;
+    using System;
 
     public interface ITransaction
     {
         Amount Amount { get; }
         string Description { get; }
+        DateTime TransactionDate { get; }
     }
 }

src/Finance.Domain/Accounts/InsuficientFundsException.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain.Accounts
 {
-    public class InsuficientFundsException : DomainException
+    public sealed class InsuficientFundsException : DomainException
     {
         internal InsuficientFundsException(string message)
             : base(message)

src/Finance.Domain/Accounts/TransactionCollection.cs

@@ -4,8 +4,14 @@
     using System.Collections.Generic;
     using System.Collections.ObjectModel;
 
-    public class TransactionCollection : Collection<ITransaction>
+    public sealed class TransactionCollection : Collection<ITransaction>
     {
+        public ITransaction GetLastTransaction()
+        {
+            ITransaction transaction = Items[Items.Count - 1];
+            return transaction;
+        }
+
         public void Add(IEnumerable<ITransaction> transactions)
         {
             foreach (var transaction in transactions)
@@ -17,7 +23,7 @@ public void Add(IEnumerable<ITransaction> transactions)
         public Amount GetCurrentBalance()
         {
             Amount totalAmount = 0;
-            
+
             foreach (var item in Items)
             {
                 if (item is Debit)

src/Finance.Domain/Customers/AccountCollection.cs

@@ -4,7 +4,7 @@
     using System;
     using System.Collections.ObjectModel;
 
-    public class AccountCollection : Collection<Guid>
+    public sealed class AccountCollection : Collection<Guid>
     {
         public void Add(IEnumerable<Guid> accounts)
         {

src/Finance.Domain/Customers/Customer.cs

@@ -1,10 +1,11 @@
 namespace Finance.Domain.Customers
 {
     using System;
+    using System.Collections.Generic;
     using System.Collections.ObjectModel;
     using Finance.Domain.ValueObjects;
 
-    public class Customer : IEntity, IAggregateRoot
+    public sealed class Customer : IEntity, IAggregateRoot
     {
         public Guid Id { get; }
         public Name Name { get; }

src/Finance.Domain/IAggregateRoot.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain
 {
-    public interface IAggregateRoot : IEntity
+    internal interface IAggregateRoot : IEntity
     {
     }
 }

src/Finance.Domain/IEntity.cs

@@ -2,7 +2,7 @@
 {
     using System;
 
-    public interface IEntity
+    internal interface IEntity
     {
         Guid Id { get; }
     }

src/Finance.Domain/ValueObjects/Amount.cs

@@ -2,7 +2,7 @@
 
 namespace Finance.Domain.ValueObjects
 {
-    public class Amount
+    public sealed class Amount
     {
         private double _value;
 
@@ -16,6 +16,11 @@ public override string ToString()
             return _value.ToString();
         }
 
+        public static implicit operator double(Amount value)
+        {
+            return value._value;
+        }
+
         public static Amount operator -(Amount value)
         {
             return new Amount(Math.Abs(value._value) * -1);

src/Finance.Domain/ValueObjects/InvalidSSNException.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain.ValueObjects
 {
-    public class InvalidSSNException : DomainException
+    internal sealed class InvalidSSNException : DomainException
     {
         internal InvalidSSNException(string message)
             : base(message)

src/Finance.Domain/ValueObjects/Name.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain.ValueObjects
 {
-    public class Name
+    public sealed class Name
     {
         private string _text;
 
@@ -22,6 +22,11 @@ public static implicit operator Name(string text)
             return new Name(text);
         }
 
+        public static implicit operator string(Name name)
+        {
+            return name._text;
+        }
+
         public override bool Equals(object obj)
         {
             if (ReferenceEquals(null, obj))

src/Finance.Domain/ValueObjects/NameShouldNotBeEmptyException.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain.ValueObjects
 {
-    public class NameShouldNotBeEmptyException : DomainException
+    public sealed class NameShouldNotBeEmptyException : DomainException
     {
         internal NameShouldNotBeEmptyException(string message)
             : base(message)

src/Finance.Domain/ValueObjects/SSN.cs

@@ -1,8 +1,8 @@
-using System.Text.RegularExpressions;
-
-namespace Finance.Domain.ValueObjects
+namespace Finance.Domain.ValueObjects
 {
-    public class SSN
+    using System.Text.RegularExpressions;
+
+    public sealed class SSN
     {
         public string _text { get; private set; }
         const string RegExForValidation = @"^\d{6,8}[-|(\s)]{0,1}\d{4}$";
@@ -31,6 +31,11 @@ public static implicit operator SSN(string text)
             return new SSN(text);
         }
 
+        public static implicit operator string(SSN ssn)
+        {
+            return ssn._text;
+        }
+
         public override bool Equals(object obj)
         {
             if (ReferenceEquals(null, obj))

src/Finance.Domain/ValueObjects/SSNShouldNotBeEmptyException.cs

@@ -1,6 +1,6 @@
 namespace Finance.Domain.ValueObjects
 {
-    public class SSNShouldNotBeEmptyException : DomainException
+    public sealed class SSNShouldNotBeEmptyException : DomainException
     {
         internal SSNShouldNotBeEmptyException(string message)
             : base(message)

test/Finance.Domain.Tests/AmountTests.cs

@@ -18,7 +18,7 @@ public void Positive_Amount_Should_Be_Created()
 
             //
             // Assert
-            Assert.Equal(positiveAmount, amount);
+            Assert.Equal<double>(positiveAmount, amount);
         }
 
         [Fact]