Skip to content

Commit 7a145d2

Browse files
committed
docs(CONTRIBUTING): add Other platform, note current node requirement
1 parent abe6c19 commit 7a145d2

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

CONTRIBUTING.md

+12-7
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,8 @@ You can reach out to us directly via Discord direct messages or Twitter if you'd
4848

4949
#### Project Owners
5050

51-
- [Salakar](https://github.com/Salakar)
52-
- Twitter: [@mikediarmid](https://twitter.com/mikediarmid)
53-
- Discord: `Salakar#1337`
5451
- [Ehesp](https://github.com/Ehesp)
55-
- Twitter: [@elliothesp](https://twitter.com/elliothesp)
52+
- Twitter: [@elliothesp](https://x.com/elliothesp)
5653
- Discord: `Alias#3980`
5754

5855
---
@@ -81,7 +78,7 @@ Working on your first Pull Request? You can learn how from this _free_ series, [
8178
```
8279
- If a method works on both platforms then there's no need to annotate it
8380
- Name your native code methods the same as the JS method name
84-
- e.g. the Android (`@ReactMethod`) implementation of `firebase.auth().signInWithEmailAndPassword()` is named `signInWithEmailAndPassword`
81+
- e.g. the Android (`@ReactMethod`) implementation of `signInWithEmailAndPassword()` is named `signInWithEmailAndPassword`
8582

8683
---
8784

@@ -100,8 +97,7 @@ cd react-native-firebase
10097

10198
```bash
10299
yarn
103-
yarn lerna:prepare
104-
yarn tests:ios:pod:install
100+
yarn lerna:prepare # Note, requires very current node, e.g., node v22.19.1+
105101
brew tap wix/brew
106102
brew install applesimutils xcbeautify
107103
```
@@ -134,11 +130,20 @@ To run end-to-end tests for `Android`, please run:
134130

135131
To run end-to-end tests for `iOS`, please run:
136132

133+
- `yarn tests:ios:pod:install`
137134
- `yarn tests:ios:build` - builds `iOS` test application.
138135
- `yarn tests:packager:jet-reset-cache` - runs JavaScript bundler.
139136
- `yarn tests:emulator:start` - runs Firestore emulator for Firestore tests.
140137
- `yarn tests:ios:test` - runs tests using Detox library. Tests for each package can be found in the `e2e` directory (i.e. `[PACKAGE]/e2e/*.e2e.js`)
141138

139+
To run end-to-end tests for `Other`, please run:
140+
141+
- `yarn tests:macos:pod:install`
142+
- `yarn tests:macos:build` - builds `iOS` test application.
143+
- `yarn tests:packager:jet-reset-cache` - runs JavaScript bundler.
144+
- `yarn tests:emulator:start` - runs Firestore emulator for Firestore tests.
145+
- `yarn tests:macos:test-cover` - runs tests using Detox library. Tests for each package can be found in the `e2e` directory (i.e. `[PACKAGE]/e2e/*.e2e.js`)
146+
142147
See its local testing guide [here](https://github.com/invertase/react-native-firebase/blob/main/tests/README.md) to get started
143148
with `e2e` testing this project.
144149

0 commit comments

Comments
 (0)