Skip to content

Commit 87a61ff

Browse files
committed
README: Updates to thoughts about 3-pane view
1 parent 16b9b70 commit 87a61ff

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

README.md

+8-3
Original file line numberDiff line numberDiff line change
@@ -184,21 +184,26 @@ Currently, `diffedit3` could be used to resolve conflicts by putting the file
184184
with conflict markers in the center and the left/right sides on the sides. There
185185
are a few limitations:
186186

187-
- The tool currently does not work correctly if the arguments are files as opposed
187+
- (Fixed in `diffedit3 0.5.0`) The tool currently does not work correctly if the arguments are files as opposed
188188
to directories. This can be fixed (TODO). So, it does not work with `jj resolve`.
189-
- Such a view would show many distracting useless diffs that can be trivially resolved
189+
- (**Update:** To be fixed in `jj` as described below) Such a view would show many distracting useless diffs that can be trivially resolved
190190
(and should be resolved in the center panel). The user would need help navigating
191191
to the relevant parts (conflicts).
192192
- AFAIK, CodeMirror's merge plugin does not support `Go to next/previous conflict`
193193
button that would go to the next diff where the center pane differs from both
194194
left and right sides. (This would also correspond to going to the next conflict in
195195
the view I described, there's no need to look at conflict markers for this)
196196

197-
Alternatively, a tool like `jj` could adjust the left/right sides to remove the
197+
(**Update:** This is the plan.) Alternatively, a tool like `jj` could adjust the left/right sides to remove the
198198
diffs that can be trivially resolved before sending the files to `diffedit3`. This would
199199
make the conflicts much easier to navigate for experienced users, but more confusing for
200200
new users.
201201

202+
**Update:** To reduce confusion, we might eventually show different views
203+
of the merge: the original files, the simplified files as described in
204+
the previous paragraph, the original jj conflict view vs the version
205+
edited by the user.
206+
202207
### Resolving merge conflicts in a 4-pane view
203208

204209
A UI that shows the base of the conflict, the two sides of the conflict, and an

0 commit comments

Comments
 (0)