-
Notifications
You must be signed in to change notification settings - Fork 15
JSS to CSS or SCSS #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also, I would need to create folders for each Component so it does not get messed up with all JSX and SCSS files in the same folder. Does this architecture suit you : ComponentXXX [folder] |
Thanks for raising this issue @tanohzana , currently the library itself doesn't contain any styling solution but does have a 'styled-components' as a peer dependency and this is also kinda bad. I'd gladly review your work if you're willing to contribute, but before that I'm planning to rewrite this package to get rid of old tools it depending on, so I think it'd be much better if you working on it afterwards. What's your thought? |
No problem. I'd be glad to help. Just say the word 🙂 |
@tanohzana I've done rewriting recently via this commit b2a94b7 |
I am just opening this issue to sum up what you wrote in your TODOs.
I can definitely do that over the week end if you're down, then open a PR so you can review and merge 😉
Would you prefer CSS or SCSS ?
The text was updated successfully, but these errors were encountered: