Skip to content

fix total updates in epoch #37783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix total updates in epoch #37783

wants to merge 5 commits into from
+43 −5

Conversation

efsotr
Copy link
Contributor

@efsotr efsotr commented Apr 25, 2025 •
edited
Loading

What does this PR do?

described in #37777
fix errors in #34198

Fixes #37777

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @muellerzr @SunMarc

Sorry, something went wrong.

@efsotr
fix total updates in epoch
Loading
Loading status checks…
08e7c02
@github-actions github-actions bot marked this pull request as draft April 25, 2025 07:53
@github-actions GitHub Actions
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@efsotr efsotr marked this pull request as ready for review April 25, 2025 08:07
@Rocketknight1
Copy link
Member

cc @SunMarc

SunMarc
SunMarc reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! can you add a test ?

efsotr and others added 2 commits April 26, 2025 19:34
@efsotr
add test; fix max_steps
Loading
Loading status checks…
49f322c
@efsotr
Merge branch 'main' into fix_tot_update_steps_in_epoch
Loading
Loading status checks…
5ab7fd8
@efsotr
Copy link
Contributor Author

efsotr commented Apr 26, 2025 •
edited
Loading

@SunMarc test added

@efsotr efsotr requested a review from SunMarc April 28, 2025 03:26
@efsotr
Copy link
Contributor Author

efsotr commented Apr 28, 2025

@ArthurZucker @muellerzr @SunMarc @Rocketknight1

@efsotr
Copy link
Contributor Author

efsotr commented Apr 29, 2025

@SunMarc test added

@efsotr
Copy link
Contributor Author

efsotr commented Apr 30, 2025

cc @ArthurZucker @muellerzr @SunMarc @Rocketknight1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach-huggingface zach-huggingface

@SunMarc SunMarc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Trainer] tot update steps is incorrect
3 participants
@efsotr @Rocketknight1 @SunMarc