Skip to content

Commit 8eb2954

Browse files
committed
Pin to pip 9.0.2 for pipenv users only
This addresses an issue raised by @CaseyFeist during code review: Updating pip for pipenv users or requiring them to update without a heads up won't be a good experience (our version is old enough that they'll need to uninstall and reinstall pipenv locally to successfully update). If you can refactor this to stay pinned to current version for pipenv users only, I should be able to accept this (and the related project updates). #833 (comment)
1 parent 468d27a commit 8eb2954

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

bin/compile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ for file in "$BUILD_DIR/runtime.txt" "$CACHE_DIR/.heroku/python-version" ; do
7777
esac
7878
done
7979

80+
if [[ -f "$BUILD_DIR/Pipfile" ]]; then
81+
# Do not force pipenv users to re-install pipenv locally.
82+
PIP_UPDATE="9.0.2"
83+
fi
84+
8085
export DEFAULT_PYTHON_STACK PIP_UPDATE
8186
export PY37 PY36 PY35 PY27 PY34
8287

0 commit comments

Comments
 (0)