Skip to content

Commit 1438056

Browse files
committed
PHP 8.4 compatibility for Composer platform package installer plugin
We currently perform the install using a bootstrapped minimal 8.3, but it doesn't hurt to be ready.
1 parent 110dc1b commit 1438056

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

support/installer/composer.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"type": "composer-plugin",
33
"name": "heroku/installer-plugin",
4-
"version": "1.7.1",
4+
"version": "1.7.2",
55
"autoload": {
66
"psr-4": {
77
"Heroku\\Buildpack\\PHP\\": "src/"
@@ -13,6 +13,7 @@
1313
"plugin-modifies-install-path": true
1414
},
1515
"require": {
16-
"composer-plugin-api": "^2.3.0"
16+
"composer-plugin-api": "^2.3.0",
17+
"php": ">=7.1"
1718
}
1819
}

support/installer/src/NoopDownloader.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ public function getInstallationSource(): string
2424
return "dist";
2525
}
2626

27-
public function download(PackageInterface $package, string $path, PackageInterface $prevPackage = null): PromiseInterface
27+
public function download(PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface
2828
{
2929
return \React\Promise\resolve(null);
3030
}
3131

32-
public function prepare(string $type, PackageInterface $package, string $path, PackageInterface $prevPackage = null): PromiseInterface
32+
public function prepare(string $type, PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface
3333
{
3434
return \React\Promise\resolve(null);
3535
}
@@ -50,7 +50,7 @@ public function remove(PackageInterface $package, string $path): PromiseInterfac
5050
return \React\Promise\resolve(null);
5151
}
5252

53-
public function cleanup(string $type, PackageInterface $package, string $path, PackageInterface $prevPackage = null): PromiseInterface
53+
public function cleanup(string $type, PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface
5454
{
5555
return \React\Promise\resolve(null);
5656
}

0 commit comments

Comments
 (0)