Skip to content

Commit 72c37f7

Browse files
authored
Heroku-20 Stack End-of-life (#1408)
* As [announced here](https://devcenter.heroku.com/changelog-items/3230), the `heroku-20` stack is no longer supported for builds on Heroku. This PR drops all references for the now end-of-life stack. * Update CHANGELOG.md Signed-off-by: Colin Casey <[email protected]> --------- Signed-off-by: Colin Casey <[email protected]>
1 parent 7f38097 commit 72c37f7

File tree

7 files changed

+11
-15
lines changed

7 files changed

+11
-15
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Steps to reproduce the behavior:
2020
4. See error
2121

2222
**Versions (please complete the following information):**
23-
- Heroku Stack: [e.g. `heroku-20`]
23+
- Heroku Stack: [e.g. `heroku-22`]
2424
- Node Version: [e.g. `15.0.0`]
2525
- NPM or Yarn Version: [e.g. `Yarn 1.22.10`]
2626
- Buildpack Version: [e.g. `heroku/nodejs v175`] (We will try to do our best to support you, but please note that we can only provide support for the latest release of the buildpack.)

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
options: --user root
1818
strategy:
1919
matrix:
20-
stack_number: ["20", "22", "24"]
20+
stack_number: ["22", "24"]
2121
env:
2222
STACK: heroku-${{ matrix.stack_number }}
2323
steps:
@@ -33,7 +33,7 @@ jobs:
3333
options: --user root
3434
strategy:
3535
matrix:
36-
stack_number: ["20", "22", "24"]
36+
stack_number: ["22", "24"]
3737
env:
3838
STACK: heroku-${{ matrix.stack_number }}
3939
steps:

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## [Unreleased]
44

5+
- Drop all support and references to the now end-of-life `heroku-20` stack. ([#1408](https://github.com/heroku/heroku-buildpack-nodejs/pull/1408))
56

67
## [v290] - 2025-04-24
78

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ make test
110110
Or to just test a specific stack:
111111

112112
```
113-
make heroku-20-build
114113
make heroku-22-build
114+
make heroku-24-build
115115
```
116116

117117
The tests are run via the vendored

lib/failure.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ log_other_failures() {
480480
meta_set "failure" "libc6-incompatibility"
481481
warn "This Node.js version is not compatible with the current stack.
482482
483-
For Node.js versions 18 and greater, heroku-20 or newer is required.
483+
For Node.js versions 18 and greater, heroku-22 or newer is required.
484484
Consider updating to a stack that is compatible with the Node.js version
485485
or pinning the Node.js version to be compatible with the current
486486
stack." https://help.heroku.com/R7DTSTD0

makefile

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ build-resolver-linux: .build
1010
cargo install heroku-nodejs-utils --root .build --bin resolve_version --git https://github.com/heroku/buildpacks-nodejs --target x86_64-unknown-linux-musl --profile release
1111
mv .build/bin/resolve_version lib/vendor/resolve-version-linux
1212

13-
test: heroku-22-build heroku-20-build heroku-24-build
13+
test: heroku-22-build heroku-24-build
1414

1515
test-binary:
1616
go test -v ./cmd/... -tags=integration
@@ -31,11 +31,6 @@ heroku-22-build:
3131
@docker run -v $(shell pwd):/buildpack:ro --rm -it -e "STACK=heroku-22" heroku/heroku:22-build bash -c 'cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run;'
3232
@echo ""
3333

34-
heroku-20-build:
35-
@echo "Running tests in docker (heroku-20-build)..."
36-
@docker run -v $(shell pwd):/buildpack:ro --rm -it -e "STACK=heroku-20" heroku/heroku:20-build bash -c 'cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run;'
37-
@echo ""
38-
3934
hatchet:
4035
@echo "Running hatchet integration tests..."
4136
@bash etc/ci-setup.sh

spec/hatchet/stack_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
describe "Stack Changes" do
44
#Test upgrading stack invalidates the cache
55
it "should not restore cached directories" do
6-
Hatchet::Runner.new("default-node", stack: "heroku-20").deploy do |app, heroku|
7-
app.update_stack("heroku-22")
6+
Hatchet::Runner.new("default-node", stack: "heroku-22").deploy do |app, heroku|
7+
app.update_stack("heroku-24")
88
app.commit!
99
app.push!
1010
expect(app.output).to include("Cached directories were not restored due to a change in version of node, npm, yarn or stack")
@@ -13,8 +13,8 @@
1313

1414
#Test cache for regular deploys is used on repeated deploys
1515
it "should not restore cache if the stack did not change" do
16-
Hatchet::Runner.new('default-node', stack: "heroku-20").deploy do |app, heroku|
17-
app.update_stack("heroku-20")
16+
Hatchet::Runner.new('default-node', stack: "heroku-22").deploy do |app, heroku|
17+
app.update_stack("heroku-24")
1818
app.commit!
1919
app.push!
2020
expect(app.output).to_not include("Cached directories were not restored due to a change in version of node, npm, yarn or stack")

0 commit comments

Comments
 (0)