File tree Expand file tree Collapse file tree 7 files changed +11
-15
lines changed Expand file tree Collapse file tree 7 files changed +11
-15
lines changed Original file line number Diff line number Diff line change @@ -20,7 +20,7 @@ Steps to reproduce the behavior:
20
20
4 . See error
21
21
22
22
** Versions (please complete the following information):**
23
- - Heroku Stack: [ e.g. ` heroku-20 ` ]
23
+ - Heroku Stack: [ e.g. ` heroku-22 ` ]
24
24
- Node Version: [ e.g. ` 15.0.0 ` ]
25
25
- NPM or Yarn Version: [ e.g. ` Yarn 1.22.10 ` ]
26
26
- Buildpack Version: [ e.g. ` heroku/nodejs v175 ` ] (We will try to do our best to support you, but please note that we can only provide support for the latest release of the buildpack.)
Original file line number Diff line number Diff line change 17
17
options : --user root
18
18
strategy :
19
19
matrix :
20
- stack_number : ["20", " 22", "24"]
20
+ stack_number : ["22", "24"]
21
21
env :
22
22
STACK : heroku-${{ matrix.stack_number }}
23
23
steps :
33
33
options : --user root
34
34
strategy :
35
35
matrix :
36
- stack_number : ["20", " 22", "24"]
36
+ stack_number : ["22", "24"]
37
37
env :
38
38
STACK : heroku-${{ matrix.stack_number }}
39
39
steps :
Original file line number Diff line number Diff line change 2
2
3
3
## [ Unreleased]
4
4
5
+ - Drop all support and references to the now end-of-life ` heroku-20 ` stack. ([ #1408 ] ( https://github.com/heroku/heroku-buildpack-nodejs/pull/1408 ) )
5
6
6
7
## [ v290] - 2025-04-24
7
8
Original file line number Diff line number Diff line change @@ -110,8 +110,8 @@ make test
110
110
Or to just test a specific stack:
111
111
112
112
```
113
- make heroku-20-build
114
113
make heroku-22-build
114
+ make heroku-24-build
115
115
```
116
116
117
117
The tests are run via the vendored
Original file line number Diff line number Diff line change @@ -480,7 +480,7 @@ log_other_failures() {
480
480
meta_set " failure" " libc6-incompatibility"
481
481
warn " This Node.js version is not compatible with the current stack.
482
482
483
- For Node.js versions 18 and greater, heroku-20 or newer is required.
483
+ For Node.js versions 18 and greater, heroku-22 or newer is required.
484
484
Consider updating to a stack that is compatible with the Node.js version
485
485
or pinning the Node.js version to be compatible with the current
486
486
stack." https://help.heroku.com/R7DTSTD0
Original file line number Diff line number Diff line change @@ -10,7 +10,7 @@ build-resolver-linux: .build
10
10
cargo install heroku-nodejs-utils --root .build --bin resolve_version --git https://github.com/heroku/buildpacks-nodejs --target x86_64-unknown-linux-musl --profile release
11
11
mv .build/bin/resolve_version lib/vendor/resolve-version-linux
12
12
13
- test : heroku-22-build heroku-20-build heroku- 24-build
13
+ test : heroku-22-build heroku-24-build
14
14
15
15
test-binary :
16
16
go test -v ./cmd/... -tags=integration
@@ -31,11 +31,6 @@ heroku-22-build:
31
31
@docker run -v $(shell pwd) :/buildpack:ro --rm -it -e " STACK=heroku-22" heroku/heroku:22-build bash -c ' cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run;'
32
32
@echo " "
33
33
34
- heroku-20-build :
35
- @echo " Running tests in docker (heroku-20-build)..."
36
- @docker run -v $(shell pwd) :/buildpack:ro --rm -it -e " STACK=heroku-20" heroku/heroku:20-build bash -c ' cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run;'
37
- @echo " "
38
-
39
34
hatchet :
40
35
@echo " Running hatchet integration tests..."
41
36
@bash etc/ci-setup.sh
Original file line number Diff line number Diff line change 3
3
describe "Stack Changes" do
4
4
#Test upgrading stack invalidates the cache
5
5
it "should not restore cached directories" do
6
- Hatchet ::Runner . new ( "default-node" , stack : "heroku-20 " ) . deploy do |app , heroku |
7
- app . update_stack ( "heroku-22 " )
6
+ Hatchet ::Runner . new ( "default-node" , stack : "heroku-22 " ) . deploy do |app , heroku |
7
+ app . update_stack ( "heroku-24 " )
8
8
app . commit!
9
9
app . push!
10
10
expect ( app . output ) . to include ( "Cached directories were not restored due to a change in version of node, npm, yarn or stack" )
13
13
14
14
#Test cache for regular deploys is used on repeated deploys
15
15
it "should not restore cache if the stack did not change" do
16
- Hatchet ::Runner . new ( 'default-node' , stack : "heroku-20 " ) . deploy do |app , heroku |
17
- app . update_stack ( "heroku-20 " )
16
+ Hatchet ::Runner . new ( 'default-node' , stack : "heroku-22 " ) . deploy do |app , heroku |
17
+ app . update_stack ( "heroku-24 " )
18
18
app . commit!
19
19
app . push!
20
20
expect ( app . output ) . to_not include ( "Cached directories were not restored due to a change in version of node, npm, yarn or stack" )
You can’t perform that action at this time.
0 commit comments