File tree Expand file tree Collapse file tree 3 files changed +7
-4
lines changed Expand file tree Collapse file tree 3 files changed +7
-4
lines changed Original file line number Diff line number Diff line change @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
7
7
8
8
## [ Unreleased]
9
9
10
+ ### Changed
11
+
12
+ - The ` PIP_PYTHON ` env var is now only set at build time. ([ #307 ] ( https://github.com/heroku/buildpacks-python/pull/307 ) )
13
+
10
14
### Removed
11
15
12
16
- Stopped setting the ` LANG ` env var. ([ #306 ] ( https://github.com/heroku/buildpacks-python/pull/306 ) )
Original file line number Diff line number Diff line change @@ -54,11 +54,11 @@ pub(crate) fn install_dependencies(
54
54
. map_err ( PipDependenciesLayerError :: CreateVenvCommand ) ?;
55
55
56
56
let mut layer_env = LayerEnv :: new ( )
57
- // Since pip is installed in a different layer (outside of this venv) , we have to explicitly
58
- // tell it to perform operations against this venv instead of the global Python install.
57
+ // pip is installed in a separate build-only layer , we have to explicitly tell it to
58
+ // perform operations against this venv instead of the global Python install.
59
59
// https://pip.pypa.io/en/stable/cli/pip/#cmdoption-python
60
60
. chainable_insert (
61
- Scope :: All ,
61
+ Scope :: Build ,
62
62
ModificationBehavior :: Override ,
63
63
"PIP_PYTHON" ,
64
64
& layer_path,
Original file line number Diff line number Diff line change @@ -85,7 +85,6 @@ fn pip_basic_install_and_cache_reuse() {
85
85
formatdoc! { "
86
86
LD_LIBRARY_PATH=/layers/heroku_python/venv/lib:/layers/heroku_python/python/lib
87
87
PATH=/layers/heroku_python/venv/bin:/layers/heroku_python/python/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
88
- PIP_PYTHON=/layers/heroku_python/venv
89
88
PYTHONHOME=/layers/heroku_python/python
90
89
PYTHONUNBUFFERED=1
91
90
VIRTUAL_ENV=/layers/heroku_python/venv
You can’t perform that action at this time.
0 commit comments