Skip to content

Commit f2f9f0a

Browse files
authored
Improve Node.js release verification script (#1104)
* Use `--fail` when downloading files
1 parent 4d4ec8e commit f2f9f0a

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

common/bin/download-verify-node

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,11 @@ fi
1919

2020
echo "Downloading Node.js release artifacts..." >&2
2121

22-
curl -o "node-v${version_number}-${platform}.tar.gz" \
23-
"https://nodejs.org/download/release/v${version_number}/node-v${version_number}-${platform}.tar.gz"
22+
curl -O "https://nodejs.org/download/release/v${version_number}/node-v${version_number}-${platform}.tar.gz" --fail
2423

25-
curl -o "SHASUMS256.txt" \
26-
-O "https://nodejs.org/dist/v${version_number}/SHASUMS256.txt"
24+
curl -O "https://nodejs.org/dist/v${version_number}/SHASUMS256.txt" --fail
2725

28-
curl -o "SHASUMS256.txt.sig" \
29-
-O "https://nodejs.org/dist/v${version_number}/SHASUMS256.txt.sig"
26+
curl -O "https://nodejs.org/dist/v${version_number}/SHASUMS256.txt.sig" --fail
3027

3128
echo "Checking Node.js integrity..." >&2
3229
grep "node-v${version_number}-${platform}.tar.gz" SHASUMS256.txt | sha256sum -c -
@@ -40,7 +37,7 @@ gpg --keyserver hkps://keys.openpgp.org --recv-keys 8FCCA13FEF1D0C2E91008E09770F
4037
gpg --keyserver hkps://keys.openpgp.org --recv-keys 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 # Rafael Gonzaga
4138
gpg --keyserver hkps://keys.openpgp.org --recv-keys C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C # Richard Lau
4239
gpg --keyserver hkps://keys.openpgp.org --recv-keys 108F52B48DB57BB0CC439B2997B01419BD92F80A # Ruy Adorno
43-
gpg --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0 # Ulises Gascónne
40+
gpg --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0 # Ulises Gascón
4441

4542
echo "Verifying Node.js gpg signature..." >&2
4643
gpg --verify SHASUMS256.txt.sig SHASUMS256.txt

0 commit comments

Comments
 (0)