Fix overriding blanked out axis_text

fixes #931

Author: has2k1

doc/changelog.qmd

@@ -102,6 +102,9 @@ title: Changelog
 
 - Fixed theming of minor x axis ticks.
 
+- Fixed theming of `axis_text`, `axis_text_x` and  `axis_text_y` so when they can be
+  overriden if previously set to `element_blank()`.
+
 ## v0.14.5
 (2025-01-02)
 [![](https://zenodo.org/badge/DOI/10.5281/zenodo.14587381.svg)](https://doi.org/10.5281/zenodo.14587381)

plotnine/themes/themeable.py

@@ -894,13 +894,28 @@ class axis_text_x(MixinSequenceOfValues):
 
     def apply_ax(self, ax: Axes):
         super().apply_ax(ax)
-        self.set(ax.get_xticklabels())
+
+        # TODO: Remove this code when the minimum matplotlib >= 3.10.0,
+        # and use the commented one below it
+        import matplotlib as mpl
+        from packaging import version
+
+        vinstalled = version.parse(mpl.__version__)
+        v310 = version.parse("3.10.0")
+        name = "labelbottom" if vinstalled >= v310 else "labelleft"
+        if not ax.xaxis.get_tick_params()[name]:
+            return
+
+        # if not ax.xaxis.get_tick_params()["labelbottom"]:
+        #     return
+
+        labels = [t.label1 for t in ax.xaxis.get_major_ticks()]
+        self.set(labels)
 
     def blank_ax(self, ax: Axes):
         super().blank_ax(ax)
-        ax.xaxis.set_tick_params(
-            which="both", labelbottom=False, labeltop=False
-        )
+        for t in ax.xaxis.get_major_ticks():
+            t.label1.set_visible(False)
 
 
 class axis_text_y(MixinSequenceOfValues):
@@ -927,13 +942,17 @@ class axis_text_y(MixinSequenceOfValues):
 
     def apply_ax(self, ax: Axes):
         super().apply_ax(ax)
-        self.set(ax.get_yticklabels())
+
+        if not ax.yaxis.get_tick_params()["labelleft"]:
+            return
+
+        labels = [t.label1 for t in ax.yaxis.get_major_ticks()]
+        self.set(labels)
 
     def blank_ax(self, ax: Axes):
         super().blank_ax(ax)
-        ax.yaxis.set_tick_params(
-            which="both", labelleft=False, labelright=False
-        )
+        for t in ax.yaxis.get_major_ticks():
+            t.label1.set_visible(False)
 
 
 class axis_text(axis_text_x, axis_text_y):

tests/baseline_images/test_theme/override_axis_text.png

@@ -14,6 +14,7 @@
     geom_point,
     ggplot,
     labs,
+    lims,
     theme,
     theme_538,
     theme_bw,
@@ -269,3 +270,16 @@ def test_theme_xkcd():
         assert p != "theme_gray"
     else:
         assert p == "theme_xkcd"
+
+
+def test_override_axis_text():
+    p = (
+        ggplot()
+        + lims(x=(0, 100), y=(0, 100))
+        + theme(
+            axis_text=element_blank(),
+            axis_text_x=element_text(color="purple", margin={"t": 4}),
+        )
+    )
+
+    assert p == "override_axis_text"