Skip to content

Fix WP Dashboard stories #10623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
techanvil opened this issue Apr 10, 2025 · 1 comment
Open
1 task

Fix WP Dashboard stories #10623

techanvil opened this issue Apr 10, 2025 · 1 comment
Assignees
Labels
Next Up Issues to prioritize for definition P1 Medium priority Type: Bug Something isn't working Type: Infrastructure Engineering infrastructure & tooling

Comments

@techanvil
Copy link
Collaborator

techanvil commented Apr 10, 2025

Fix WP Dashboard stories.

Bug Description

Most of the WP Dashboard stories are no longer working properly and need to be fixed.

Steps to reproduce

  1. Navigate to the following Storybook components:
    a. Views > WPDashboardApp > WPDashboardActivateAnalyticsCTA
    b. Views > WPDashboardApp > WPDashboardPopularPagesGA4
    c. Views > WPDashboardApp > WPDashboardSessionDurationGA4
    d. Views > WPDashboardApp > WPDashboardUniqueVisitorsChartGA4
    e. Views > WPDashboardApp > WPDashboardUniqueVisitorsGA4
    f. Views > WPDashboardApp > WPDashboardWidgets
  2. For each component, see how some or all of the stories are incorrect, either showing the loading state out of context, or simply rendering an empty/broken layout.

Screenshots

For example, here's the WPDashboardWidgets component, incorrectly displaying the loading state for its Ready story:

Image

Additional Context

  • PHP Version: any
  • OS: any
  • Browser: any
  • Plugin Version: raised at 1.150.0
  • Device: any

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The stories listed in steps to reproduce should all display as intended.
  • A VRT scenario should be added for the WPDashboardApp/WPDashboardWidgets/Ready story to help prevent the stories getting broken again in future.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@techanvil techanvil added P1 Medium priority Type: Bug Something isn't working Type: Infrastructure Engineering infrastructure & tooling Next Up Issues to prioritize for definition labels Apr 10, 2025
@hussain-t hussain-t self-assigned this Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Up Issues to prioritize for definition P1 Medium priority Type: Bug Something isn't working Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

3 participants
@techanvil @hussain-t and others