Run code style checks on pre-submit

We now use the Spotless plugin to run ktlint and
keep our code style in check. It also does copyright header
checking.

This CL also updates the build script to run the `check`
task which will invoke spotless and lint, to make sure
we don't commit things that shouldn't be.

Change-Id: Ief6510eb8018ec4d40f996fbec3beb7fb6aef005

Author: Chris Banes

build.gradle

@@ -95,6 +95,10 @@ buildscript {
     }
 }
 
+plugins {
+    id "com.diffplug.gradle.spotless" version "3.17.0"
+}
+
 allprojects {
     repositories {
         google()
@@ -113,6 +117,13 @@ allprojects {
     }
 }
 
-task clean(type: Delete) {
-    delete rootProject.buildDir
+subprojects {
+    apply plugin: 'com.diffplug.gradle.spotless'
+    spotless {
+        kotlin {
+            target "**/*.kt"
+            ktlint("0.29.0")
+            licenseHeaderFile project.rootProject.file('copyright.kt')
+        }
+    }
 }

copyright.kt

@@ -0,0 +1,16 @@
+/*
+ * Copyright $YEAR Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+

mobile/build.gradle

@@ -100,6 +100,9 @@ android {
     }
 
     lintOptions {
+        // Running lint over the debug variant is enough
+        checkReleaseBuilds false
+
         disable "InvalidPackage", "MissingTranslation"
     }
 

mobile/src/main/java/com/google/samples/apps/iosched/di/ActivityBindingModule.kt

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package com.google.samples.apps.iosched.di
 
 import com.google.samples.apps.iosched.shared.di.ActivityScoped

mobile/src/main/java/com/google/samples/apps/iosched/ui/MainActivity.kt

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package com.google.samples.apps.iosched.ui
 
 import android.app.Activity

mobile/src/main/java/com/google/samples/apps/iosched/ui/signin/NotificationsPreferenceDialogFragment.kt

@@ -39,7 +39,7 @@ class NotificationsPreferenceDialogFragment : DaggerAppCompatDialogFragment() {
         return MaterialAlertDialogBuilder(requireContext())
             .setTitle(R.string.notifications_preference_dialog_title)
             .setMessage(R.string.notifications_preference_dialog_content)
-            .setNegativeButton(R.string.no) { _, _ ->  notificationsPrefSaveActionUseCase(false) }
+            .setNegativeButton(R.string.no) { _, _ -> notificationsPrefSaveActionUseCase(false) }
             .setPositiveButton(R.string.yes) { _, _ -> notificationsPrefSaveActionUseCase(true) }
             .setOnDismissListener { notificationsPrefShownActionUseCase(true) }
             .create()

mobile/src/main/java/com/google/samples/apps/iosched/ui/signin/SignOutDialogFragment.kt

@@ -25,7 +25,6 @@ import com.google.samples.apps.iosched.shared.result.EventObserver
 import com.google.samples.apps.iosched.shared.util.viewModelProvider
 import com.google.samples.apps.iosched.ui.signin.SignInEvent.RequestSignOut
 import com.google.samples.apps.iosched.util.signin.SignInHandler
-import dagger.android.AndroidInjector
 import dagger.android.support.DaggerAppCompatDialogFragment
 import javax.inject.Inject
 

mobile/src/main/java/com/google/samples/apps/iosched/util/FirebaseAnalyticsHelper.kt

@@ -1,11 +1,11 @@
 /*
- * Copyright 2014 Google Inc. All rights reserved.
+ * Copyright 2019 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,

mobile/src/main/java/com/google/samples/apps/iosched/widget/transition/Rotate.kt

@@ -1,18 +1,19 @@
 /*
- * Copyright (C) 2018 The Android Open Source Project
+ * Copyright 2018 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package com.google.samples.apps.iosched.widget.transition
 
 import android.animation.Animator

model/src/main/java/com/google/samples/apps/iosched/model/Block.kt

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package com.google.samples.apps.iosched.model
 
 import org.threeten.bp.ZonedDateTime

shared/src/main/java/com/google/samples/apps/iosched/shared/fcm/IoschedFirebaseInstanceIDService.kt

@@ -18,8 +18,6 @@ package com.google.samples.apps.iosched.shared.fcm
 
 import com.google.firebase.iid.FirebaseInstanceId
 
-import timber.log.Timber
-
 /**
  * Service that receives new FCM ID Tokens.
  */

tv/build.gradle

@@ -51,6 +51,7 @@ android {
             matchingFallbacks = ['debug']
         }
 
+
         debug {
             manifestPlaceholders = [crashlyticsEnabled: false]
         }
@@ -60,6 +61,9 @@ android {
     }
 
     lintOptions {
+        // Running lint over the debug variant is enough
+        checkReleaseBuilds false
+
         disable "InvalidPackage", "MissingTranslation"
     }
 

tv/src/main/java/com/google/samples/apps/iosched/tv/ui/sessiondetail/SessionDetailFragment.kt

@@ -17,7 +17,6 @@
 package com.google.samples.apps.iosched.tv.ui.sessiondetail
 
 import android.content.Context
-import android.graphics.Bitmap
 import android.os.Bundle
 import android.widget.Toast
 import androidx.core.content.ContextCompat
@@ -28,16 +27,11 @@ import androidx.leanback.widget.ClassPresenterSelector
 import androidx.leanback.widget.DetailsOverviewRow
 import androidx.leanback.widget.DiffCallback
 import androidx.leanback.widget.FullWidthDetailsOverviewRowPresenter
-import androidx.leanback.widget.FullWidthDetailsOverviewSharedElementHelper
 import androidx.leanback.widget.HeaderItem
 import androidx.leanback.widget.ListRow
 import androidx.leanback.widget.ListRowPresenter
 import androidx.leanback.widget.OnActionClickedListener
 import androidx.lifecycle.Observer
-import com.bumptech.glide.Glide
-import com.bumptech.glide.request.RequestOptions
-import com.bumptech.glide.request.target.SimpleTarget
-import com.bumptech.glide.request.transition.Transition
 import com.google.samples.apps.iosched.model.Session
 import com.google.samples.apps.iosched.model.Speaker
 import com.google.samples.apps.iosched.shared.util.SpeakerUtils
@@ -53,7 +47,7 @@ import com.google.samples.apps.iosched.tv.util.toArrayObjectAdapter
 import javax.inject.Inject
 
 private const val ACTION_WATCH = 1L
-//private const val ACTION_STAR = 2L
+// private const val ACTION_STAR = 2L
 
 /**
  * Displays the details for a [Session].