Skip to content

Commit 97ed2b7

Browse files
committed
support cases where no value is passed in for ignore_not_found
1 parent 94f8e48 commit 97ed2b7

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

lib/entitlements/backend/github_team/service.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,19 @@ class TeamNotFound < RuntimeError; end
1818

1919
# Constructor.
2020
#
21-
# addr - Base URL a GitHub Enterprise API (leave undefined to use dotcom)
22-
# org - String with organization name
23-
# token - Access token for GitHub API
24-
# ou - Base OU for fudged DNs
21+
# addr - Base URL a GitHub Enterprise API (leave undefined to use dotcom)
22+
# org - String with organization name
23+
# token - Access token for GitHub API
24+
# ou - Base OU for fudged DNs
25+
# ignore_not_found - Boolean to ignore not found errors
2526
#
2627
# Returns nothing.
2728
Contract C::KeywordArgs[
2829
addr: C::Maybe[String],
2930
org: String,
3031
token: String,
3132
ou: String,
32-
ignore_not_found: C::Bool,
33+
ignore_not_found: C::Maybe[C::Bool],
3334
] => C::Any
3435
def initialize(addr: nil, org:, token:, ou:, ignore_not_found: false)
3536
super

lib/entitlements/service/github.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,19 @@ class GitHub
2121

2222
# Constructor.
2323
#
24-
# addr - Base URL a GitHub Enterprise API (leave undefined to use dotcom)
25-
# org - String with organization name
26-
# token - Access token for GitHub API
27-
# ou - Base OU for fudged DNs
24+
# addr - Base URL a GitHub Enterprise API (leave undefined to use dotcom)
25+
# org - String with organization name
26+
# token - Access token for GitHub API
27+
# ou - Base OU for fudged DNs
28+
# ignore_not_found - Boolean to ignore not found errors
2829
#
2930
# Returns nothing.
3031
Contract C::KeywordArgs[
3132
addr: C::Maybe[String],
3233
org: String,
3334
token: String,
3435
ou: String,
35-
ignore_not_found: C::Bool,
36+
ignore_not_found: C::Maybe[C::Bool],
3637
] => C::Any
3738
def initialize(addr: nil, org:, token:, ou:, ignore_not_found: false)
3839
# Save some parameters for the connection but don't actually connect yet.

0 commit comments

Comments
 (0)