Skip to content
This repository was archived by the owner on Aug 13, 2020. It is now read-only.

Commit da6178b

Browse files
authored
force encode user agent to utf-8 and show encoding in rollbar error (#1212)
1 parent c6547c6 commit da6178b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/controllers/impressions_controller.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ def create_impression
4040
@virtual_impression[:ad_template],
4141
@virtual_impression[:ad_theme],
4242
request.remote_ip,
43-
request.user_agent,
43+
request.user_agent.force_encoding(Encoding::UTF_8),
4444
Time.current.iso8601
4545
)
4646
rescue Encoding::UndefinedConversionError => e
47-
Rollbar.error "#{e} => #{@virtual_impression_id}, #{@virtual_impression[:campaign_id]}, #{@virtual_impression[:property_id]}, #{@virtual_impression[:creative_id]}, #{@virtual_impression[:ad_template]}, #{@virtual_impression[:ad_theme]}, #{request.remote_ip}, #{request.user_agent}, #{Time.current.iso8601}"
47+
Rollbar.error "#{e} => #{@virtual_impression_id.encoding}, #{@virtual_impression[:campaign_id].encoding}, #{@virtual_impression[:property_id].encoding}, #{@virtual_impression[:creative_id].encoding}, #{@virtual_impression[:ad_template].encoding}, #{@virtual_impression[:ad_theme].encoding}, #{request.remote_ip.encoding}, #{request.user_agent.encoding}, #{Time.current.iso8601}"
4848
end
4949
end

0 commit comments

Comments
 (0)