drop comments table (#1201)

fixes #1192

Author: andrewmcodes

Gemfile

@@ -7,7 +7,6 @@ ruby "2.6.6"
 
 gem "active_link_to", "~> 1.0.5"
 gem "active_storage_svg_sanitizer", "~> 0.1.0"
-gem "acts_as_commentable_with_threading", "~> 2.0.1"
 gem "aws-sdk-s3", "~> 1.61.1", require: false
 gem "barnes", "~> 0.0.7"
 gem "bootsnap", ">= 1.4.2", require: false

Gemfile.lock

@@ -67,19 +67,13 @@ GEM
       minitest (~> 5.1)
       tzinfo (~> 1.1)
       zeitwerk (~> 2.2)
-    acts_as_commentable_with_threading (2.0.1)
-      activerecord (>= 4.0)
-      activesupport (>= 4.0)
-      awesome_nested_set (>= 3.0)
     addressable (2.7.0)
       public_suffix (>= 2.0.2, < 5.0)
     annotate (3.1.0)
       activerecord (>= 3.2, < 7.0)
       rake (>= 10.4, < 14.0)
     ansi (1.5.0)
     ast (2.4.0)
-    awesome_nested_set (3.2.0)
-      activerecord (>= 4.0.0, < 7.0)
     awesome_print (1.8.0)
     aws-eventstream (1.0.3)
     aws-partitions (1.288.0)
@@ -589,7 +583,6 @@ PLATFORMS
 DEPENDENCIES
   active_link_to (~> 1.0.5)
   active_storage_svg_sanitizer (~> 0.1.0)
-  acts_as_commentable_with_threading (~> 2.0.1)
   annotate
   awesome_print
   aws-sdk-s3 (~> 1.61.1)

PROSPECTUS.md

@@ -71,7 +71,7 @@ Each template uses an ad creative that follows these guidelines:
 
 * Ad creative **headline** + **body** should not be more than **84 characters long**.
 * Banner image may not be animated.
-* We recomment the use of 👋 emoji when it makes sense, but don't overuse it.
+* We recommend the use of 👋 emoji when it makes sense, but don't overuse it.
 
 We are software developers first and foremost. We will help you craft a message that resonates with the developer community if needed.
 

app/models/campaign.rb

@@ -253,7 +253,6 @@ class Campaign < ApplicationRecord
   tag_columns :audience_ids
   tag_columns :keywords
   tag_columns :negative_keywords
-  acts_as_commentable
   has_paper_trail on: %i[create update destroy], version_limit: nil, only: %i[
     core_hours_only
     country_codes

app/models/comment.rb

@@ -71,7 +71,6 @@ class Organization < ApplicationRecord
   # additional config (i.e. accepts_nested_attribute_for etc...) ..............
   attr_accessor :skip_validation
   monetize :balance_cents, numericality: true
-  acts_as_commentable
   has_paper_trail on: %i[update destroy], only: %i[
     name
   ]

app/models/organization.rb

@@ -142,7 +142,6 @@ class Property < ApplicationRecord
   tag_columns :prohibited_advertiser_ids
   tag_columns :keywords
   has_one_attached :screenshot
-  acts_as_commentable
   has_paper_trail on: %i[update], only: %i[
     ad_template
     ad_theme

app/models/property.rb

@@ -180,7 +180,6 @@ class User < ApplicationRecord
   )
   has_one_attached :avatar
   accepts_nested_attributes_for :organization_users, reject_if: proc { |attributes| attributes["organization_id"].blank? || attributes["role"].blank? }
-  acts_as_commentable
   has_paper_trail on: %i[update], only: %i[
     api_access
     api_key

app/models/user.rb

@@ -0,0 +1,21 @@
+class DropCommentsTable < ActiveRecord::Migration[6.0]
+  def up
+    drop_table :comments
+  end
+
+  def down
+    create_table :comments, force: true do |t|
+      t.bigint :commentable_id
+      t.string :commentable_type
+      t.string :title
+      t.text :body
+      t.string :subject
+      t.bigint :user_id, null: false
+      t.bigint :parent_id, :lft, :rgt
+      t.timestamps
+    end
+
+    add_index :comments, :user_id
+    add_index :comments, [:commentable_id, :commentable_type]
+  end
+end

db/migrate/20200406223804_drop_comments_table.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_03_25_201726) do
+ActiveRecord::Schema.define(version: 2020_04_06_223804) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_stat_statements"
@@ -119,22 +119,6 @@
     t.index ["weekdays_only"], name: "index_campaigns_on_weekdays_only"
   end
 
-  create_table "comments", force: :cascade do |t|
-    t.bigint "commentable_id", null: false
-    t.string "commentable_type", null: false
-    t.string "title"
-    t.text "body"
-    t.string "subject"
-    t.bigint "user_id", null: false
-    t.bigint "parent_id"
-    t.integer "lft"
-    t.integer "rgt"
-    t.datetime "created_at", null: false
-    t.datetime "updated_at", null: false
-    t.index ["commentable_id", "commentable_type"], name: "index_comments_on_commentable_id_and_commentable_type"
-    t.index ["user_id"], name: "index_comments_on_user_id"
-  end
-
   create_table "coupons", force: :cascade do |t|
     t.string "code", null: false
     t.string "description"

db/schema.rb

@@ -296,45 +296,6 @@ CREATE SEQUENCE public.campaigns_id_seq
 ALTER SEQUENCE public.campaigns_id_seq OWNED BY public.campaigns.id;
 
 
---
--- Name: comments; Type: TABLE; Schema: public; Owner: -
---
-
-CREATE TABLE public.comments (
-    id bigint NOT NULL,
-    commentable_id bigint NOT NULL,
-    commentable_type character varying NOT NULL,
-    title character varying,
-    body text,
-    subject character varying,
-    user_id bigint NOT NULL,
-    parent_id bigint,
-    lft integer,
-    rgt integer,
-    created_at timestamp without time zone NOT NULL,
-    updated_at timestamp without time zone NOT NULL
-);
-
-
---
--- Name: comments_id_seq; Type: SEQUENCE; Schema: public; Owner: -
---
-
-CREATE SEQUENCE public.comments_id_seq
-    START WITH 1
-    INCREMENT BY 1
-    NO MINVALUE
-    NO MAXVALUE
-    CACHE 1;
-
-
---
--- Name: comments_id_seq; Type: SEQUENCE OWNED BY; Schema: public; Owner: -
---
-
-ALTER SEQUENCE public.comments_id_seq OWNED BY public.comments.id;
-
-
 --
 -- Name: coupons; Type: TABLE; Schema: public; Owner: -
 --
@@ -1401,13 +1362,6 @@ ALTER TABLE ONLY public.campaign_bundles ALTER COLUMN id SET DEFAULT nextval('pu
 ALTER TABLE ONLY public.campaigns ALTER COLUMN id SET DEFAULT nextval('public.campaigns_id_seq'::regclass);
 
 
---
--- Name: comments id; Type: DEFAULT; Schema: public; Owner: -
---
-
-ALTER TABLE ONLY public.comments ALTER COLUMN id SET DEFAULT nextval('public.comments_id_seq'::regclass);
-
-
 --
 -- Name: coupons id; Type: DEFAULT; Schema: public; Owner: -
 --
@@ -1567,14 +1521,6 @@ ALTER TABLE ONLY public.campaigns
     ADD CONSTRAINT campaigns_pkey PRIMARY KEY (id);
 
 
---
--- Name: comments comments_pkey; Type: CONSTRAINT; Schema: public; Owner: -
---
-
-ALTER TABLE ONLY public.comments
-    ADD CONSTRAINT comments_pkey PRIMARY KEY (id);
-
-
 --
 -- Name: coupons coupons_pkey; Type: CONSTRAINT; Schema: public; Owner: -
 --
@@ -2146,20 +2092,6 @@ CREATE INDEX index_campaigns_on_user_id ON public.campaigns USING btree (user_id
 CREATE INDEX index_campaigns_on_weekdays_only ON public.campaigns USING btree (weekdays_only);
 
 
---
--- Name: index_comments_on_commentable_id_and_commentable_type; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX index_comments_on_commentable_id_and_commentable_type ON public.comments USING btree (commentable_id, commentable_type);
-
-
---
--- Name: index_comments_on_user_id; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX index_comments_on_user_id ON public.comments USING btree (user_id);
-
-
 --
 -- Name: index_coupons_on_code; Type: INDEX; Schema: public; Owner: -
 --
@@ -2912,6 +2844,5 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20200220160136'),
 ('20200221220825'),
 ('20200303224134'),
-('20200325201726');
-
-
+('20200325201726'),
+('20200406223804');