change tests to use pest

Author: gdespirito

.travis.yml

@@ -20,8 +20,7 @@
     "php": ">=5.4.0"
   },
   "require-dev": {
-    "codeception/codeception": "^2.1",
-    "codeception/specify": "^0.4.3",
+    "pestphp/pest": "^3.8",
     "rector/rector": "^2.0"
   },
   "autoload": {
@@ -38,5 +37,10 @@
         "Rut": "Freshwork\\ChileanBundle\\Facades\\Rut"
       }
     }
+  },
+  "config": {
+    "allow-plugins": {
+      "pestphp/pest-plugin": true
+    }
   }
 }

codeception.yml

@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit backupGlobals="false"
-         backupStaticAttributes="false"
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
-         syntaxCheck="false"
 >
     <testsuites>
-        <testsuite name="Package Test Suite">
-            <directory suffix=".php">./tests/</directory>
+        <testsuite name="Unit">
+            <directory>./tests/Unit</directory>
         </testsuite>
     </testsuites>
+    <source>
+        <include>
+            <directory>./src</directory>
+        </include>
+    </source>
+    <php>
+      
+    </php>
 </phpunit>

composer.json

@@ -11,6 +11,6 @@
     ])
     // uncomment to reach your current PHP version
     ->withPhpSets()
-    ->withTypeCoverageLevel(0)
-    ->withDeadCodeLevel(0)
-    ->withCodeQualityLevel(0);
+    ->withTypeCoverageLevel(9)
+    ->withDeadCodeLevel(9)
+    ->withCodeQualityLevel(9);

phpunit.xml

@@ -58,14 +58,14 @@ class Rut
      * The number part of the RUT. Example: 12.345.678-9 ($rut = 12345678)
      * @var integer
      */
-    protected $number = null;
+    protected $number;
 
     /**
      * Verification Number of the RUT
      * The verification number part of the RUT. Example: 12.345.678-9 ($vn = 9)
      * @var string
      */
-    protected $vn = null;
+    protected $vn;
 
     /**
      *
@@ -104,7 +104,7 @@ public function __construct($rut = null, $vn = null)
      */
     public static function parse($rut)
     {
-        list($rut, $vn) = self::split($rut);
+        [$rut, $vn] = self::split($rut);
 
         return (new self($rut, $vn));
     }
@@ -203,13 +203,16 @@ public function vnSeparator(?array $vnSeparator = null)
     public function isValid()
     {
         if (!$this->hasValidFormat()) {
+            if ($this->useExceptions) {
+                throw new InvalidFormatException("R.U.T. '{$this->number}' with verification code '{$this->vn}' has an invalid format");
+            }
             return false;
         }
 
         $vn_has_to_be = $this->calculateVerificationNumber();
         if ($this->vn == $vn_has_to_be) {
             return true;
-        }
+        };
 
         return false;
     }
@@ -244,7 +247,7 @@ public function calculateVerificationNumber()
         $rut = $this->number;
         $s=1;
         for ($m=0; $rut != 0; $rut /= 10) {
-            $s=((int)$s+(int)$rut % (int)10 * ((int)9-(int)$m++%(int)6))%(int)11;
+            $s=($s+(int)$rut % 10 * (9-$m++%6))%11;
         }
         return chr($s?$s+47:75);
     }
@@ -346,12 +349,23 @@ public function format($format = self::FORMAT_COMPLETE)
      */
     public function hasValidFormat()
     {
-        $is_ok = (preg_match('/^[0-9]+$/', $this->number) && preg_match('/([K0-9])$/', $this->vn) && strlen($this->number) > $this->minChars && strlen($this->number) < $this->maxChars);
-        if (!$is_ok && $this->useExceptions) {
-            throw new InvalidFormatException("R.U.T. '{$this->number}' with verification code '{$this->vn}' has an invalid format");
+        if (strlen($this->number) >= $this->maxChars) {
+            return false;
+        }
+
+        if (strlen($this->number) <= $this->minChars) {
+            return false;
+        }
+
+        if (!preg_match('/([K0-9])$/', $this->vn)) {
+            return false;
+        }
+
+        if (!preg_match('/^[0-9]+$/', $this->number)) {
+            return false;
         }
 
-        return $is_ok;
+        return true;
     }
 
     /**

rector.php

@@ -0,0 +1,56 @@
+<?php
+
+/*
+|--------------------------------------------------------------------------
+| Test Case
+|--------------------------------------------------------------------------
+|
+| The closure you provide to your test functions is always bound to a specific PHPUnit test
+| case class. By default, that class is "PHPUnit\Framework\TestCase". Of course, you may
+| need to change it using the "uses()" function to bind a different classes or traits.
+|
+*/
+
+// uses(Tests\TestCase::class)->in('Feature');
+
+/*
+|--------------------------------------------------------------------------
+| Expectations
+|--------------------------------------------------------------------------
+|
+| When you're writing tests, you often need to check that values meet certain conditions. The
+| "expect()" function gives you access to a set of "expectations" methods that you can use
+| to assert different things. Of course, you may extend the Expectation API at any time.
+|
+*/
+
+expect()->extend('toBeValidRut', function () {
+    return $this->toBeTruthy()
+               ->and($this->value->validate())->toBeTrue();
+});
+
+/*
+|--------------------------------------------------------------------------
+| Functions
+|--------------------------------------------------------------------------
+|
+| While Pest is very powerful out-of-the-box, you may have some testing code specific to your
+| project that you don't want to repeat in every file. Here you can also expose helpers as
+| global functions to help you to reduce the number of lines of code in your test files.
+|
+*/
+
+function createRut(string $rut)
+{
+    return \Freshwork\ChileanBundle\Rut::parse($rut);
+}
+
+function validRuts()
+{
+    return ['11.111.111-1', '111111111', '11111112-K', '11111112-k'];
+}
+
+function invalidRuts()
+{
+    return ['11111112-9', '17601065fail-7', '123-1', '123.456.789-2', '11.111.111-L'];
+}