Skip to content

Commit ad32a79

Browse files
committed
PR comments'
1 parent e91b5d3 commit ad32a79

File tree

10 files changed

+82
-76
lines changed

10 files changed

+82
-76
lines changed

src/components/BecomeAProvider.svelte

Lines changed: 28 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -10,35 +10,33 @@
1010
import BackHomeButton from '$components/BackHomeButton.svelte';
1111
</script>
1212

13-
<div id="become-a-provider" class="column w-single-block">
14-
<BlockSection title="Become a Provider">
15-
<form class="">
16-
<SelectNetworkAndAccount
17-
bind:newUser={$user}
18-
accounts={$nonProviderAccountsStore}
19-
accountSelectorTitle="Select an Account Id"
20-
accountSelectorPlaceholder="Select an Account Id"
21-
noAccountsFoundErrorMsg="No accounts found. Add an Account Id to your wallet."
22-
/>
23-
{#if $user?.network != null && $user.network.id === NetworkType.MAINNET}
24-
<EmailProviderRequest />
25-
{:else if $user && $user?.address !== ''}
26-
{#if $user?.msaId === 0}
27-
<CreateMsa />
28-
{:else}
29-
<CreateProvider />
30-
{/if}
13+
<BlockSection title="Become a Provider">
14+
<form class="">
15+
<SelectNetworkAndAccount
16+
bind:newUser={$user}
17+
accounts={$nonProviderAccountsStore}
18+
accountSelectorTitle="Select an Account Id"
19+
accountSelectorPlaceholder="Select an Account Id"
20+
noAccountsFoundErrorMsg="No accounts found. Add an Account Id to your wallet."
21+
/>
22+
{#if $user?.network != null && $user.network.id === NetworkType.MAINNET}
23+
<EmailProviderRequest />
24+
{:else if $user && $user?.address !== ''}
25+
{#if $user?.msaId === 0}
26+
<CreateMsa />
3127
{:else}
32-
<BackHomeButton cancelText="Back" />
28+
<CreateProvider />
3329
{/if}
34-
</form>
35-
</BlockSection>
36-
<BlockSection title="More Info">
37-
<div class="text-sm">
38-
For developer and testing convenience, on Testnet, anyone with an MSA who wishes to become a Provider may simply
39-
submit a createProvider transaction.<br /><br />This action will register the MSA Id that is controlled by the
40-
selected Transaction Signing Address above. Any Account Id that has been added to the MSA can submit the
41-
transaction.
42-
</div>
43-
</BlockSection>
44-
</div>
30+
{:else}
31+
<BackHomeButton cancelText="Back" />
32+
{/if}
33+
</form>
34+
</BlockSection>
35+
<BlockSection title="More Info">
36+
<div class="text-sm">
37+
For developer and testing convenience, on Testnet, anyone with an MSA who wishes to become a Provider may simply
38+
submit a createProvider transaction.<br /><br />This action will register the MSA Id that is controlled by the
39+
selected Transaction Signing Address above. Any Account Id that has been added to the MSA can submit the
40+
transaction.
41+
</div>
42+
</BlockSection>

src/components/DropDownMenu.svelte

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,46 @@
88
export let formatter: (value: T) => string = (value) => value.toString(); // eslint-disable-line no-undef
99
</script>
1010

11-
<div class="column mb-f24 w-full max-w-[420px]">
12-
<label for={id}>{label}</label>
11+
<div class="column freq-select my-f24 w-full max-w-[420px]">
12+
<label class="font-bold" for={id}>{label}</label>
1313
<select
1414
{...$$restProps}
1515
{id}
1616
bind:value
1717
on:change={onChange}
1818
data-test-id={id}
19-
class="mr-f32 max-w-[420px] rounded-xl align-middle text-black"
19+
class="freq-select relative m-0 mt-f8 max-w-[420px] cursor-pointer appearance-none rounded-md bg-white p-2 pr-f32 align-middle outline outline-1 outline-gray3 active:shadow-md"
2020
>
21-
<option value="" class="text-black" disabled selected>{placeholder}</option>
21+
<option class="text-gray3" value={null} disabled>{placeholder}</option>
2222
{#each options as option}
2323
<option value={option}>{formatter(option)}</option>
2424
{/each}
2525
</select>
26+
<div class="select-arrow"></div>
2627
</div>
28+
29+
<style lang="postcss">
30+
.freq-select {
31+
position: relative;
32+
}
33+
.freq-select::after {
34+
content: '';
35+
position: absolute;
36+
pointer-events: none;
37+
top: 72%;
38+
right: 10px;
39+
transform: translate(0, -50%);
40+
width: 12px;
41+
height: 12px;
42+
background-color: #000000;
43+
clip-path: polygon(8% 17%, 0% 25%, 50% 84%, 100% 25%, 92% 17%, 50% 65%);
44+
}
45+
.freq-select select {
46+
-webkit-appearance: none;
47+
48+
&:focus,
49+
&:hover {
50+
@apply outline-teal;
51+
}
52+
}
53+
</style>

src/components/FAQItem.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
<button
1616
id="faq-question"
17-
class="label border-divider mt-2 flex w-full items-center justify-between border-t p-4 text-left text-md"
17+
class="label border-divider mt-2 flex w-full items-center justify-between border-t p-4 text-left text-md font-bold md:text-lg"
1818
onclick={toggleIsOpen}
1919
>
2020
{@render question?.()}
@@ -33,6 +33,6 @@
3333
</svg>
3434
</button>
3535

36-
<div id="faq-answer" class={`p-3 ${isOpen ? 'block' : 'hidden'}`}>
36+
<div id="faq-answer" class="text-md lg:text-[22px] {`p-3 ${isOpen ? 'block' : 'hidden'}`}">
3737
{@render answer?.()}
3838
</div>

src/components/Header.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<header class="mb-8 flex items-start justify-between gap-3">
99
<div>
10-
<div class="w-[140px] max-w-48 pb-1 pl-3 md:min-w-40">
10+
<div class="w-[180px] max-w-[180px] pb-1 pl-3 md:min-w-40">
1111
<FrequencyLogo />
1212
</div>
1313
<p class="pl-3 text-sm font-semibold md:text-md md:text-normal lg:tracking-wider">Provider Dashboard</p>

src/components/LoginForm.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
accountSelectorPlaceholder="Select a Provider Account Id"
3636
noAccountsFoundErrorMsg="No Provider Account Ids found. To become a Provider, see below."
3737
/>
38-
<div class="flex justify-between align-bottom">
38+
<div class="mt-f24 flex justify-between align-bottom">
3939
<Button
4040
class="hover-teal px-f12 py-f8 disabled:bg-gray3"
4141
type="primary"

src/components/ProviderLogin.svelte

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,18 @@
55
import { Button } from '@frequency-chain/style-guide';
66
</script>
77

8-
<div id="provider-login">
9-
<BlockSection title="Provider Login">
10-
<LoginForm />
11-
</BlockSection>
8+
<BlockSection title="Provider Login">
9+
<LoginForm />
10+
</BlockSection>
1211

13-
<BlockSection title="Not a Provider?">
14-
<div class="text-sm">
15-
<a href="https://docs.frequency.xyz/Delegation/Providers.html" target="_blank" rel="no-referrer" class="underline"
16-
>Want to learn more about providers?
17-
</a>
18-
</div>
19-
<Button class="px-f12 py-f8" href="/become-a-provider">Become a Provider</Button>
20-
</BlockSection>
21-
<BlockSection title="Need tokens?">
22-
<HowToTransact additionalStyles="text-sm" />
23-
</BlockSection>
24-
</div>
12+
<BlockSection title="Not a Provider?">
13+
<div class="py-f24 text-sm">
14+
<a href="https://docs.frequency.xyz/Delegation/Providers.html" target="_blank" rel="no-referrer" class="underline"
15+
>Want to learn more about providers?
16+
</a>
17+
</div>
18+
<Button class="px-f12 py-f8" href="/become-a-provider">Become a Provider</Button>
19+
</BlockSection>
20+
<BlockSection title="Need tokens?">
21+
<HowToTransact additionalStyles="text-sm" />
22+
</BlockSection>

src/components/SelectNetworkAndAccount.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
formatter={formatNetwork}
139139
/>
140140
{:else}
141-
<p class="mb-f24 flex justify-between">
141+
<p class="my-f24 flex justify-between">
142142
<span class="text-teal">Connected to {selectedNetwork?.name || 'Custom'}</span>
143143
<span onclick={resetState} class="cursor-pointer underline">Change networks</span>
144144
</p>

src/components/icons/FrequencyLogo.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
xmlns="http://www.w3.org/2000/svg"
88
xmlns:xlink="http://www.w3.org/1999/xlink"
99
{width}
10-
height="48.256"
10+
height="100%"
1111
viewBox="0 0 461.117 68.256"
1212
>
1313
<defs>

src/routes/faq/+page.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import HowToTransact from '$components/HowToTransact.svelte';
44
</script>
55

6-
<div class="content-block w-single-block text-left text-base">
7-
<h2 class="section-title">FAQ's</h2>
6+
<div class="content-block">
7+
<h4 class="text-md font-bold md:text-xl">FAQ's</h4>
88

99
<FAQItem>
1010
{#snippet question()}

src/style/app.css

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
@apply ml-6 list-decimal;
3232
}
3333
.column {
34-
@apply flex flex-col md:gap-4;
34+
@apply flex flex-col;
3535
}
3636

3737
/* typography */
@@ -100,23 +100,6 @@
100100
footer svg {
101101
@apply bg-white text-black transition duration-[0.3s] hover:text-teal;
102102
}
103-
104-
select {
105-
@apply m-0 cursor-pointer overflow-clip bg-transparent p-2 pr-f32 text-black outline-none outline-1 outline-gray3;
106-
107-
&:focus,
108-
&:hover {
109-
@apply outline-teal;
110-
}
111-
112-
option:first-child {
113-
@apply text-gray3 !important;
114-
}
115-
}
116-
117-
::placeholder {
118-
@apply text-gray2 !important;
119-
}
120103
}
121104
}
122105

0 commit comments

Comments
 (0)