Skip to content

Commit fa04839

Browse files
committed
fix: formatting
1 parent 1c7328f commit fa04839

File tree

2 files changed

+56
-40
lines changed

2 files changed

+56
-40
lines changed

pallets/msa/src/benchmarking.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,7 @@ mod benchmarks {
373373
fn withdraw_tokens() -> Result<(), BenchmarkError> {
374374
prep_signature_registry::<T>();
375375

376-
let (msa_public_key, msa_key_pair, msa_id) =
377-
create_msa_account_and_keys::<T>();
376+
let (msa_public_key, msa_key_pair, msa_id) = create_msa_account_and_keys::<T>();
378377

379378
let eth_account_id: H160 = Msa::<T>::msa_id_to_eth_address(msa_id);
380379
let mut bytes = &EthereumAddressMapper::to_bytes32(&eth_account_id.0)[..];
@@ -386,13 +385,11 @@ mod benchmarks {
386385
T::Currency::set_balance(&msa_account_id, balance);
387386
assert_eq!(T::Currency::balance(&msa_account_id), balance);
388387

389-
let (add_key_payload, _, new_account_id) =
390-
add_key_payload_and_signature::<T>(msa_id);
388+
let (add_key_payload, _, new_account_id) = add_key_payload_and_signature::<T>(msa_id);
391389

392390
let encoded_add_key_payload = wrap_binary_data(add_key_payload.encode());
393-
let owner_signature = MultiSignature::Sr25519(
394-
msa_key_pair.sign(&encoded_add_key_payload).unwrap().into(),
395-
);
391+
let owner_signature =
392+
MultiSignature::Sr25519(msa_key_pair.sign(&encoded_add_key_payload).unwrap().into());
396393

397394
#[extrinsic_call]
398395
_(
@@ -406,7 +403,6 @@ mod benchmarks {
406403
Ok(())
407404
}
408405

409-
410406
impl_benchmark_test_suite!(
411407
Msa,
412408
crate::tests::mock::new_test_ext_keystore(),

pallets/msa/src/tests/msa_token_tests.rs

Lines changed: 52 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,38 @@
11
use frame_support::{
22
assert_noop, assert_ok,
3-
traits::{Currency, tokens::{Fortitude, Preservation, fungible::Inspect}},
3+
traits::{
4+
tokens::{fungible::Inspect, Fortitude, Preservation},
5+
Currency,
6+
},
47
};
58

69
use sp_core::{sr25519, Encode, Pair};
7-
use sp_runtime::{MultiSignature};
10+
use sp_runtime::MultiSignature;
811

9-
use crate::{
10-
tests::mock::*,
11-
types::AddKeyData,
12-
Config, Error,
13-
};
12+
use crate::{tests::mock::*, types::AddKeyData, Config, Error};
1413

1514
use common_primitives::{
16-
msa::{H160, MessageSourceId},
15+
msa::{MessageSourceId, H160},
1716
node::BlockNumber,
1817
signatures::{AccountAddressMapper, EthereumAddressMapper},
1918
utils::wrap_binary_data,
2019
};
2120

2221
use pallet_balances::Event as BalancesEvent;
2322

24-
fn generate_payload(msa_id: MessageSourceId, msa_owner_keys: &sr25519::Pair, new_public_key: &sr25519::Pair, expiration: Option<BlockNumber>) -> (AddKeyData::<Test>, Vec<u8>, MultiSignature) {
23+
fn generate_payload(
24+
msa_id: MessageSourceId,
25+
msa_owner_keys: &sr25519::Pair,
26+
new_public_key: &sr25519::Pair,
27+
expiration: Option<BlockNumber>,
28+
) -> (AddKeyData<Test>, Vec<u8>, MultiSignature) {
2529
let payload = AddKeyData::<Test> {
2630
msa_id,
2731
expiration: match expiration {
2832
Some(block_number) => block_number,
29-
None => 10
33+
None => 10,
3034
},
31-
new_public_key: new_public_key.public().into()
35+
new_public_key: new_public_key.public().into(),
3236
};
3337

3438
let encoded_payload = wrap_binary_data(payload.encode());
@@ -44,7 +48,8 @@ fn it_fails_when_caller_key_does_not_match_payload() {
4448
let (origin_key_pair, _) = sr25519::Pair::generate();
4549
let (other_key_pair, _) = sr25519::Pair::generate();
4650

47-
let (payload, _, msa_signature) = generate_payload(msa_id, &owner_key_pair, &other_key_pair, None);
51+
let (payload, _, msa_signature) =
52+
generate_payload(msa_id, &owner_key_pair, &other_key_pair, None);
4853

4954
assert_noop!(
5055
Msa::withdraw_tokens(
@@ -65,7 +70,8 @@ fn it_fails_when_payload_signature_is_invalid() {
6570
let (origin_key_pair, _) = sr25519::Pair::generate();
6671
let (other_key_pair, _) = sr25519::Pair::generate();
6772

68-
let (payload, _, msa_signature) = generate_payload(msa_id, &other_key_pair, &origin_key_pair, None);
73+
let (payload, _, msa_signature) =
74+
generate_payload(msa_id, &other_key_pair, &origin_key_pair, None);
6975

7076
assert_noop!(
7177
Msa::withdraw_tokens(
@@ -87,7 +93,8 @@ fn it_fails_when_proof_is_expired() {
8793

8894
// The current block is 1, therefore setting the proof expiration to 1 should cause
8995
// the extrinsic to fail because the proof has expired.
90-
let (payload, _, msa_signature) = generate_payload(msa_id, &owner_key_pair, &origin_key_pair, Some(1));
96+
let (payload, _, msa_signature) =
97+
generate_payload(msa_id, &owner_key_pair, &origin_key_pair, Some(1));
9198

9299
assert_noop!(
93100
Msa::withdraw_tokens(
@@ -109,7 +116,12 @@ fn it_fails_when_proof_is_not_yet_valid() {
109116

110117
// The current block is 1, therefore setting the proof expiration to the max mortality period
111118
// should cause the extrinsic to fail
112-
let (payload, _, msa_signature) = generate_payload(msa_id, &owner_key_pair, &origin_key_pair, Some(Msa::mortality_block_limit(1)));
119+
let (payload, _, msa_signature) = generate_payload(
120+
msa_id,
121+
&owner_key_pair,
122+
&origin_key_pair,
123+
Some(Msa::mortality_block_limit(1)),
124+
);
113125

114126
assert_noop!(
115127
Msa::withdraw_tokens(
@@ -129,7 +141,8 @@ fn it_fails_when_msa_key_is_not_an_msa_control_key() {
129141
let (msa_id, owner_key_pair) = create_account();
130142
let (origin_key_pair, _) = sr25519::Pair::generate();
131143

132-
let (payload, _, msa_signature) = generate_payload(msa_id + 1, &owner_key_pair, &origin_key_pair, None);
144+
let (payload, _, msa_signature) =
145+
generate_payload(msa_id + 1, &owner_key_pair, &origin_key_pair, None);
133146

134147
assert_noop!(
135148
Msa::withdraw_tokens(
@@ -150,7 +163,8 @@ fn it_fails_when_msa_key_does_not_control_msa_in_payload() {
150163
let (origin_key_pair, _) = sr25519::Pair::generate();
151164
let (other_key_pair, _) = sr25519::Pair::generate();
152165

153-
let (payload, _, msa_signature) = generate_payload(msa_id, &other_key_pair, &origin_key_pair, None);
166+
let (payload, _, msa_signature) =
167+
generate_payload(msa_id, &other_key_pair, &origin_key_pair, None);
154168

155169
assert_noop!(
156170
Msa::withdraw_tokens(
@@ -170,7 +184,8 @@ fn it_fails_when_msa_does_not_have_a_balance() {
170184
let (msa_id, owner_key_pair) = create_account();
171185
let (origin_key_pair, _) = sr25519::Pair::generate();
172186

173-
let (payload, _, msa_signature) = generate_payload(msa_id, &owner_key_pair, &origin_key_pair, None);
187+
let (payload, _, msa_signature) =
188+
generate_payload(msa_id, &owner_key_pair, &origin_key_pair, None);
174189

175190
assert_noop!(
176191
Msa::withdraw_tokens(
@@ -193,31 +208,36 @@ fn it_succeeds_when_balance_is_sufficient() {
193208
let bytes: [u8; 32] = EthereumAddressMapper::to_bytes32(&eth_account_id.0);
194209
let msa_account_id = <Test as frame_system::Config>::AccountId::from(bytes);
195210

196-
let (payload, _, msa_signature) = generate_payload(msa_id, &owner_key_pair, &origin_key_pair, None);
211+
let (payload, _, msa_signature) =
212+
generate_payload(msa_id, &owner_key_pair, &origin_key_pair, None);
197213

198214
let transfer_amount = 10_000_000;
199215

200216
// Fund MSA
201217
let _ = <Test as Config>::Currency::deposit_creating(&msa_account_id, transfer_amount);
202218

203-
assert_ok!(
204-
Msa::withdraw_tokens(
205-
RuntimeOrigin::signed(origin_key_pair.public().into()),
206-
owner_key_pair.public().into(),
207-
msa_signature,
208-
payload
209-
)
210-
);
219+
assert_ok!(Msa::withdraw_tokens(
220+
RuntimeOrigin::signed(origin_key_pair.public().into()),
221+
owner_key_pair.public().into(),
222+
msa_signature,
223+
payload
224+
));
211225

212226
let receiver_balance = <Test as Config>::Currency::reducible_balance(
213227
&origin_key_pair.public().into(),
214228
Preservation::Expendable,
215-
Fortitude::Polite
229+
Fortitude::Polite,
216230
);
217-
assert_eq!(receiver_balance, transfer_amount, "transfer amount {} does not equal new balance {}", transfer_amount, receiver_balance);
218-
219-
System::assert_last_event(
220-
RuntimeEvent::Balances(BalancesEvent::Transfer { from: msa_account_id, to: origin_key_pair.public().into(), amount: transfer_amount }),
231+
assert_eq!(
232+
receiver_balance, transfer_amount,
233+
"transfer amount {} does not equal new balance {}",
234+
transfer_amount, receiver_balance
221235
);
236+
237+
System::assert_last_event(RuntimeEvent::Balances(BalancesEvent::Transfer {
238+
from: msa_account_id,
239+
to: origin_key_pair.public().into(),
240+
amount: transfer_amount,
241+
}));
222242
})
223243
}

0 commit comments

Comments
 (0)