minor refactor

Author: aramikm

js/ethereum-utils/sample.html

@@ -8,31 +8,21 @@
     <script src="./dist/browser/frequency-ethereum-utils.umd.js"></script>
     <script>
       console.log(EthereumUtils.EIP712_DOMAIN_DEFINITION);
-	  const signatureRequest = EthereumUtils.getEip712BrowserRequestItemizedSignaturePayloadV2(
-		  10,
-		  1982672367,
-		  100,
-		  [
-			  EthereumUtils.createItemizedAddAction('0x40a6836ea489047852d3f0297f8fe8ad6779793af4e9c6274c230c207b9b825026'),
-			  EthereumUtils.createItemizedDeleteAction(3)
-		  ]
-	  );
-	  console.log(signatureRequest);
+      const signatureRequest = EthereumUtils.getEip712BrowserRequestItemizedSignaturePayloadV2(10, 1982672367, 100, [
+        EthereumUtils.createItemizedAddAction('0x40a6836ea489047852d3f0297f8fe8ad6779793af4e9c6274c230c207b9b825026'),
+        EthereumUtils.createItemizedDeleteAction(3),
+      ]);
+      console.log(signatureRequest);
     </script>
     <script type="module">
       import * as Library from './dist/browser/frequency-ethereum-utils.esm.js';
 
       console.log(Library.ADD_KEY_DATA_DEFINITION);
-	  const signatureRequest = Library.getEip712BrowserRequestItemizedSignaturePayloadV2(
-		  10,
-		  1982672367,
-		  100,
-		  [
-			  Library.createItemizedAddAction('0x40a6836ea489047852d3f0297f8fe8ad6779793af4e9c6274c230c207b9b825026'),
-			  Library.createItemizedDeleteAction(3)
-		  ]
-	  );
-	  console.log(signatureRequest);
+      const signatureRequest = Library.getEip712BrowserRequestItemizedSignaturePayloadV2(10, 1982672367, 100, [
+        Library.createItemizedAddAction('0x40a6836ea489047852d3f0297f8fe8ad6779793af4e9c6274c230c207b9b825026'),
+        Library.createItemizedDeleteAction(3),
+      ]);
+      console.log(signatureRequest);
     </script>
   </body>
 </html>

js/ethereum-utils/src/signature.definitions.ts

@@ -21,6 +21,7 @@ export const EIP712_DOMAIN_DEFINITION = {
   ],
 };
 
+// using pallet_revive test chain ID for now.
 export const EIP712_DOMAIN_DEFAULT: EipDomainPayload = {
   name: 'Frequency',
   version: '1',

js/ethereum-utils/src/signature.ts

@@ -42,24 +42,12 @@ export async function signEip712(
   payload: SupportedPayload,
   chain: ChainType = 'Mainnet-Frequency'
 ): Promise<EcdsaSignature> {
-  // TODO: use correct chainID for different networks
-  // using pallet_revive test chain ID for now.
-  const chainId = '0x190F1B44';
-  // TODO: use correct contract address for different payloads
-  const verifyingContract = '0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC';
-
-  // Define the domain separator
-  const domainData = {
-    name: 'Frequency',
-    version: '1',
-    chainId,
-    verifyingContract,
-  };
-
   const types = getTypesFor(payload.type);
   const normalizedPayload = normalizePayload(payload);
   const wallet = new ethers.Wallet(secretKey);
-  const signature = await wallet.signTypedData(domainData, types, normalizedPayload);
+  // TODO: use correct chainID for different networks
+  // TODO: use correct contract address for different payloads
+  const signature = await wallet.signTypedData(EIP712_DOMAIN_DEFAULT, types, normalizedPayload);
   return { Ecdsa: signature } as EcdsaSignature;
 }