Check for naming length restriction before building proposal (#1960)

# Goal
The goal of this PR is to check for provider name length before bundling
a proposal that might eventually fail upon execution due to provider
name being set is too long

Closes #1654 

# Checklist
- [ ] Chain spec updated
- [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
- [ ] Design doc(s) updated
- [x] Tests added
- [ ] Benchmarks added
- [ ] Weights updated

Author: saraswatpuneet

pallets/msa/src/lib.rs

@@ -886,13 +886,16 @@ pub mod pallet {
 			origin: OriginFor<T>,
 			provider_name: Vec<u8>,
 		) -> DispatchResult {
+			let bounded_name: BoundedVec<u8, T::MaxProviderNameSize> =
+				provider_name.try_into().map_err(|_| Error::<T>::ExceedsMaxProviderNameSize)?;
+
 			let proposer = ensure_signed(origin)?;
 			Self::ensure_valid_msa_key(&proposer)?;
 
 			let proposal: Box<T::Proposal> = Box::new(
 				(Call::<T>::create_provider_via_governance {
 					provider_key: proposer.clone(),
-					provider_name,
+					provider_name: bounded_name.into(),
 				})
 				.into(),
 			);

pallets/msa/src/tests/governance_tests.rs

@@ -1,5 +1,5 @@
 use frame_support::{
-	assert_ok,
+	assert_noop, assert_ok,
 	traits::{ChangeMembers, Hash},
 };
 
@@ -8,7 +8,7 @@ use sp_weights::Weight;
 use pretty_assertions::assert_eq;
 use sp_core::{Encode, Pair};
 
-use crate::tests::mock::*;
+use crate::{tests::mock::*, Error};
 
 #[test]
 fn create_provider_via_governance_happy_path() {
@@ -121,3 +121,17 @@ fn propose_to_be_provider_happy_path() {
 		assert!(Msa::is_registered_provider(_new_msa_id));
 	})
 }
+
+#[test]
+fn propose_to_be_provider_long_name_should_fail() {
+	new_test_ext().execute_with(|| {
+		// Create a new MSA account and request that it become a provider
+		let (_new_msa_id, key_pair) = create_account();
+		let proposal_res = Msa::propose_to_be_provider(
+			RuntimeOrigin::signed(key_pair.public().into()),
+			Vec::from("this_is_a_really_long_name_that_should_fail"),
+		);
+
+		assert_noop!(proposal_res, Error::<Test>::ExceedsMaxProviderNameSize);
+	})
+}