Update Rust and CI Base Version (#2330)

# Goal
The goal of this PR is to update Rust to 1.84.1 and use the new base
image

- Re-enable cargo deny (thanks to the version bump)
- Update Rust to v1.84.1
- Update nightly version
- Update srtool
- Update to use new ci base image v1.4.0

Author: wilwade

.cargo/config.toml

@@ -1,46 +1,3 @@
-# Global lint rules. This will keep rust analyser in sync with the clippy
-# lints so every tool has the same view.
-#
-# Rustc Lints: https://doc.rust-lang.org/rustc/lints/index.html
-# Clippy Lints: https://rust-lang.github.io/rust-clippy/master/index.html
-# Substrate flags: https://github.com/paritytech/substrate/blob/master/.cargo/config.toml
-#
-# If you want standard clippy run:
-# RUSTFLAGS= cargo clippy
-[target.'cfg(feature = "cargo-clippy")']
-rustflags = [
-	# Clippy lint groups
-	"-Aclippy::all",
-	"-Dclippy::complexity",
-	"-Dclippy::correctness",
-	# Clippy individual lints
-	"-Aclippy::if_same_then_else",
-	"-Aclippy::zero_prefixed_literal",
-	"-Aclippy::type_complexity",
-	"-Aclippy::nonminimal_bool",
-	"-Aclippy::borrowed-box",
-	"-Aclippy::too_many_arguments",
-	"-Aclippy::unnecessary_cast",
-	"-Aclippy::identity_op",
-	"-Aclippy::useless_conversion",
-	"-Aclippy::unit_arg",
-	"-Aclippy::option_map_unit_fn",
-	"-Aclippy::bind_instead_of_map",
-	"-Aclippy::erasing_op",
-	"-Aclippy::eq_op",
-	"-Aclippy::while_immutable_condition",
-	"-Aclippy::needless_option_as_deref",
-	"-Aclippy::derivable_impls",
-	"-Aclippy::bool_assert_comparison",
-	"-Asuspicious_double_ref_op",
-	# Built-in lint groups
-	"-Dnonstandard-style",
-	"-Dunused",
-	# Built-in individual lints
-	# "-D<rustc_lint_name>",
-	"-Dclippy::unwrap_used",
-	"-Dclippy::expect_used",
-]
-
+# Lints are moved to Cargo.toml under [lints.clippy]
 [net]
 retry = 5

.github/workflows/check-migrations.yml

@@ -12,7 +12,7 @@ jobs:
     name: Check Migrations on Paseo
     continue-on-error: false
     runs-on: ubicloud-standard-8
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     steps:
       - name: Checkout sources
         uses: actions/checkout@v4

.github/workflows/common/codecov/action.yml

@@ -9,22 +9,25 @@ runs:
   steps:
     - name: Install grcov
       shell: bash
-      run: cargo install --locked grcov --version 0.8.20
+      run: cargo install --locked grcov --version 0.9.0
+    - name: Add llvm-tools
+      shell: bash
+      run: rustup component add llvm-tools-preview
     - name: Build
       shell: bash # Limited to 10 threads max
       run: cargo build -j 10 --features frequency-lint-check
       env:
         RUSTC_BOOTSTRAP: 1
         CARGO_INCREMENTAL: "0"
-        RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"
+        RUSTFLAGS: "-Cinstrument-coverage -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"
         RUSTDOCFLAGS: "-Cpanic=abort"
     - name: Test
       shell: bash # Limited to 10 threads max
       run: cargo test -j 10 --features frequency-lint-check
       env:
         RUSTC_BOOTSTRAP: 1
         CARGO_INCREMENTAL: "0"
-        RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"
+        RUSTFLAGS: "-Cinstrument-coverage -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"
         RUSTDOCFLAGS: "-Cpanic=abort"
     # There are a lot of things ignored here to make it all work
     # See the grcov docs for more information
@@ -53,7 +56,7 @@ runs:
           --ignore "*cargo*" \
           -o ./target/debug/lcov.info
     - name: Upload to codecov.io
-      uses: codecov/codecov-action@v4
+      uses: codecov/codecov-action@v5
       with:
         token: ${{inputs.code-cov-token}}
         files: ./target/debug/lcov.info

.github/workflows/common/srtool/action.yml

@@ -198,13 +198,10 @@ runs:
     - id: build
       name: Build ${{ env.PACKAGE }} using ${{ env.SRTOOL_IMAGE }}
       shell: bash
-      env:
-        # https://github.com/paritytech/polkadot-sdk/pull/2217
-        WASM_BUILD_STD: "0"
       run: |
         echo ::group::Srtool build of chain ${{ inputs.chain }}
         CMD="docker run -i --rm  -e CARGO_NET_RETRY=10 -e PACKAGE=${{ env.PACKAGE }} -e RUNTIME_DIR=${{ env.RUNTIME_DIR }} -e BUILD_OPTS -e
-        PARACHAIN_PALLET_ID -e AUTHORIZE_UPGRADE_PREFIX -e PROFILE -e WASM_BUILD_STD -v ${{ env.WORKDIR }}:/build ${{ env.SRTOOL_IMAGE
+        PARACHAIN_PALLET_ID -e AUTHORIZE_UPGRADE_PREFIX -e PROFILE -v ${{ env.WORKDIR }}:/build ${{ env.SRTOOL_IMAGE
         }} build --app --json -cM"
 
         echo ::debug::build::docker_run $CMD

.github/workflows/create-issue-dependabot-alert-pr.yml

@@ -10,7 +10,7 @@ on:
       - .github/workflows
 jobs:
   create-issue:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       contents: write
     env:

.github/workflows/merge-pr.yml

@@ -12,7 +12,7 @@ jobs:
   publish-js-api-augment-rc:
     name: Merge - Publish JS API Augment Release Candidate
     runs-on: ubicloud-standard-4
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4
@@ -48,8 +48,8 @@ jobs:
 
   calc-code-coverage:
     name: Merge - Calculate Code Coverage
-    runs-on: ubicloud-standard-8
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    runs-on: ubicloud-standard-30
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4

.github/workflows/release.yml

@@ -27,12 +27,11 @@ env:
   RELEASE_BRANCH_NAME: release-${{github.event.inputs.release-version || github.ref_name}}
   LATEST_FULL_RELEASE_TAG: _LATEST-FULL-RELEASE
   TEST_RUN: ${{startsWith(github.event.inputs.release-version || github.ref_name, 'v0.0.1')}}
-  RUST_TOOLCHAIN: "1.76.0" # Match to /rust-toolchain.toml
 
 jobs:
   validate-release-version:
     name: Validate Release Version
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Validate
         if: env.NEW_RELEASE_TAG_FROM_UI != ''
@@ -50,7 +49,7 @@ jobs:
   create-release-branch:
     needs: validate-release-version
     name: Create Release Branch
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4
@@ -114,7 +113,7 @@ jobs:
   version-code:
     needs: run-all-benchmarks
     name: Version Code
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4
@@ -169,7 +168,7 @@ jobs:
             build-profile: release
             release-file-name-prefix: frequency
     runs-on: ubicloud-standard-8
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     env:
       SIGNING_SUBKEY_FINGERPRINT: B6327D1474C6392032870E8EFA4FD1E73A0FE707
     steps:
@@ -311,7 +310,7 @@ jobs:
           profile: ${{matrix.build-profile}}
           package: ${{matrix.package}}
           chain: ${{matrix.chain}}
-          tag: "1.81.0"
+          tag: "1.84.1"
           runtime_dir: ${{ matrix.runtime-dir }}
       - name: Rename WASM file
         run: |
@@ -338,7 +337,7 @@ jobs:
     needs: version-code
     name: Build Rust Developer Docs
     runs-on: ubicloud-standard-4
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4
@@ -370,8 +369,8 @@ jobs:
       BIN_DIR: target/release
       RELEASE_FILENAME_PREFIX: frequency-local
       ARCH: amd64
-    runs-on: ubuntu-22.04
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    runs-on: ubuntu-24.04
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     steps:
       - name: Set Env Vars
         run: |
@@ -422,8 +421,8 @@ jobs:
 
   build-js-schemas:
     name: Build JS Schemas
-    runs-on: ubuntu-22.04
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    runs-on: ubuntu-24.04
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4
@@ -455,14 +454,14 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ubuntu-22.04]
+        os: [ubuntu-24.04]
         network: [mainnet]
         include:
           - network: mainnet
             spec: frequency
             build-profile: release
             release-file-name-prefix: frequency
-          - os: ubuntu-22.04
+          - os: ubuntu-24.04
             arch: amd64
     runs-on: ${{matrix.os}}
     steps:
@@ -510,7 +509,7 @@ jobs:
   compare-metadata:
     needs: build-binaries
     name: Compare Metadata
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     env:
       BIN_DIR: target/release
       BIN_FILENAME: frequency-local.amd64
@@ -652,7 +651,7 @@ jobs:
         build-js-schemas,
       ]
     name: Wait for All Builds to Finish
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     outputs:
       runtime_filename_dev: ${{needs.build-runtimes.outputs.runtime_filename_dev}}
       runtime_filename_mainnet: ${{needs.build-runtimes.outputs.runtime_filename_mainnet}}
@@ -664,8 +663,8 @@ jobs:
   release-artifacts:
     needs: wait-for-all-builds
     name: Release Built Artifacts
-    runs-on: ubuntu-22.04
-    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.3.1
+    runs-on: ubuntu-24.04
+    container: ghcr.io/frequency-chain/frequency/ci-base-image:1.4.0
     permissions:
       contents: write
     steps:
@@ -742,6 +741,9 @@ jobs:
       - name: Get Polkadot Version
         id: polkadot-version
         run: echo "version=$(make version-polkadot)" >> $GITHUB_OUTPUT
+      - name: Get Rust Version
+        id: rust-version
+        run: echo "version=$(rustc --version | cut -f 2 -d " ")" >> $GITHUB_OUTPUT
       - name: Download Artifacts
         id: download
         uses: actions/download-artifact@v4
@@ -782,7 +784,7 @@ jobs:
           RUNTIME_INFO_MAINNET: ${{steps.get-runtimes-info.outputs.runtime_info_mainnet}}
           IS_FULL_RELEASE: ${{steps.is-full-release.outputs.is-full-release}}
         run: |
-          ./build-release-notes.sh '${{steps.polkadot-version.outputs.version}}' \
+          ./build-release-notes.sh '${{steps.polkadot-version.outputs.version}}' '${{steps.rust-version.outputs.version}}' \
             "${CHANGELOG}" \
             "${RUNTIME_INFO_MAINNET}" \
             "${RUNTIME_INFO_PASEO}" \
@@ -860,7 +862,7 @@ jobs:
     env:
       DOCKER_HUB_PROFILE: frequencychain
       IMAGE_NAME: parachain-node
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Set Env Vars
         run: |
@@ -951,7 +953,7 @@ jobs:
             release-file-name-prefix: frequency-dev
     env:
       DOCKER_HUB_PROFILE: frequencychain
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Set Env Vars
         run: |
@@ -1028,7 +1030,7 @@ jobs:
   release-rust-developer-docs:
     needs: wait-for-all-builds
     name: Release Rust Developer Docs
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       contents: read
       pages: write
@@ -1045,7 +1047,7 @@ jobs:
   release-js-api-augment:
     needs: wait-for-all-builds
     name: Release JS API Augment
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4
@@ -1091,7 +1093,7 @@ jobs:
   release-js-schemas:
     needs: wait-for-all-builds
     name: Release JS Schemas
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v4