Fix: check_handle should apply the whitespace trimming and collapsing (#2363)

# Goal
The goal of this PR is to update the check_handle Runtime RPC to
correctly use the whitespace trim and collapse

Closes #2362

# Discussion

- I thought about updating how this gets the value to be more aligned,
but in the end the simple fix won out.

# Checklist
- [x] Unit Tests added?
- [x] Spec version incremented?

Author: wilwade

Makefile

@@ -91,7 +91,7 @@ onboard:
 	./scripts/init.sh onboard-frequency-paseo-local
 
 .PHONY: onboard-res-local
-onboard-debug:
+onboard-res-local:
 	./scripts/init.sh onboard-res-local
 
 .PHONY: onboard-docker

pallets/handles/src/lib.rs

@@ -592,6 +592,8 @@ pub mod pallet {
 
 			let base_handle_str = core::str::from_utf8(&base_handle).unwrap_or_default();
 
+			let base_handle_trimmed = trim_and_collapse_whitespace(base_handle_str);
+
 			// Convert base handle into a canonical base
 			let (_canonical_handle_str, canonical_base) =
 				Self::get_canonical_string_vec_from_base_handle(base_handle_str);
@@ -603,7 +605,7 @@ pub mod pallet {
 			let suffixes_available = suffix_index < T::HandleSuffixMax::get();
 
 			CheckHandleResponse {
-				base_handle,
+				base_handle: base_handle_trimmed.into(),
 				suffix_index,
 				suffixes_available,
 				valid,

pallets/handles/src/tests/handle_creation_tests.rs

@@ -438,6 +438,18 @@ fn test_check_handle() {
 			}
 		);
 
+		let good_whitespace_handle: String = String::from("  hel   lo  ");
+		assert_eq!(
+			Handles::check_handle(good_whitespace_handle.as_bytes().to_vec()),
+			CheckHandleResponse {
+				base_handle: "hel lo".as_bytes().to_vec(),
+				suffix_index: 0,
+				suffixes_available: true,
+				valid: true,
+				canonical_base: String::from("he110").as_bytes().to_vec(),
+			}
+		);
+
 		let too_long_handle: String = "*".repeat((HANDLE_BYTES_MAX + 1) as usize);
 		assert_eq!(
 			Handles::check_handle(too_long_handle.as_bytes().to_vec()),

runtime/frequency/src/lib.rs

@@ -435,7 +435,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: Cow::Borrowed("frequency"),
 	impl_name: Cow::Borrowed("frequency"),
 	authoring_version: 1,
-	spec_version: 153,
+	spec_version: 154,
 	impl_version: 0,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 1,
@@ -449,7 +449,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: Cow::Borrowed("frequency-testnet"),
 	impl_name: Cow::Borrowed("frequency"),
 	authoring_version: 1,
-	spec_version: 153,
+	spec_version: 154,
 	impl_version: 0,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 1,