* Refactor staking type to go in StakingTargetDetails

* Make some functions pass by reference (performance)
* fix broken tests & calls

Author: shannonwells

pallets/capacity/src/tests/other_tests.rs

@@ -96,7 +96,7 @@ fn set_target_details_is_successful() {
 		target_details.amount = 10;
 		target_details.capacity = 10;
 
-		Capacity::set_target_details_for(&staker, target, target_details);
+		Capacity::set_target_details_for(&staker, &target, &target_details);
 
 		let stored_target_details = Capacity::get_target_for(&staker, target).unwrap();
 
@@ -120,7 +120,7 @@ fn set_capacity_details_is_successful() {
 				last_replenished_epoch: 1u32,
 			};
 
-		Capacity::set_capacity_for(target, capacity_details);
+		Capacity::set_capacity_for(&target, &capacity_details);
 
 		let stored_capacity_details = Capacity::get_capacity_for(target).unwrap();
 

pallets/capacity/src/tests/testing_utils.rs

@@ -60,7 +60,7 @@ pub fn create_capacity_account_and_fund(
 	capacity_details.total_capacity_issued = available;
 	capacity_details.last_replenished_epoch = last_replenished;
 
-	Capacity::set_capacity_for(target_msa_id, capacity_details.clone());
+	Capacity::set_capacity_for(&target_msa_id, &capacity_details);
 
 	capacity_details.clone()
 }

pallets/frequency-tx-payment/src/tests/mock.rs

@@ -362,5 +362,5 @@ fn create_capacity_for(target: MessageSourceId, amount: u64) {
 	let mut capacity_details = Capacity::get_capacity_for(target).unwrap_or_default();
 	let capacity: u64 = amount / (TEST_TOKEN_PER_CAPACITY as u64);
 	capacity_details.deposit(&amount, &capacity).unwrap();
-	Capacity::set_capacity_for(target, capacity_details);
+	Capacity::set_capacity_for(&target, &capacity_details);
 }

pallets/frequency-tx-payment/src/tests/pallet_tests.rs

@@ -614,7 +614,7 @@ fn withdraw_fee_replenishes_capacity_account_on_new_epoch_before_deducting_fee()
 				total_capacity_issued,
 				last_replenished_epoch: 10,
 			};
-			Capacity::set_capacity_for(provider_msa_id, capacity_details);
+			Capacity::set_capacity_for(&provider_msa_id, &capacity_details);
 
 			let call: &<Test as Config>::RuntimeCall =
 				&RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 });
@@ -660,7 +660,7 @@ fn withdraw_fee_does_not_replenish_if_not_new_epoch() {
 				total_capacity_issued,
 				last_replenished_epoch,
 			};
-			Capacity::set_capacity_for(provider_msa_id, capacity_details);
+			Capacity::set_capacity_for(&provider_msa_id, &capacity_details);
 
 			let call: &<Test as Config>::RuntimeCall =
 				&RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 });