Skip to content

Commit 0052a5f

Browse files
authored
Fix release flow for JS packages (#2231)
# Goal The goal of this PR is to fix an issue noticed with the v1.15.1 release around JS packages. 1. The step `is-full-release` wasn't there, but GitHub was happily resolving the if conditions that tried to use it. 2. NPM changed the tag default, so `latest` was working for `api-augment` even when it shouldn't have been. For the v1.15.1 runs see: - https://github.com/frequency-chain/frequency/actions/runs/12129502202/job/33851319975 - https://github.com/frequency-chain/frequency/actions/runs/12129502202/job/33851321973
1 parent 7371f77 commit 0052a5f

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

.github/workflows/release.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1050,6 +1050,11 @@ jobs:
10501050
uses: actions/checkout@v4
10511051
with:
10521052
ref: ${{env.RELEASE_BRANCH_NAME}}
1053+
- name: Full Release?
1054+
id: is-full-release
1055+
uses: ./.github/workflows/common/is-full-release
1056+
with:
1057+
version-tag: ${{env.NEW_RELEASE_TAG}}
10531058
- name: Set up NodeJs
10541059
uses: actions/setup-node@v4
10551060
with:
@@ -1077,7 +1082,7 @@ jobs:
10771082
- name: Release Candidate on NPM
10781083
if: env.TEST_RUN != 'true' &&
10791084
steps.is-full-release.outputs.is-full-release != 'true'
1080-
run: npm publish --access public
1085+
run: npm publish --tag next --access public
10811086
working-directory: ./js/api-augment/dist
10821087
env:
10831088
NODE_AUTH_TOKEN: ${{secrets.NODE_AUTH_TOKEN}}
@@ -1091,6 +1096,11 @@ jobs:
10911096
uses: actions/checkout@v4
10921097
with:
10931098
ref: ${{env.RELEASE_BRANCH_NAME}}
1099+
- name: Full Release?
1100+
id: is-full-release
1101+
uses: ./.github/workflows/common/is-full-release
1102+
with:
1103+
version-tag: ${{env.NEW_RELEASE_TAG}}
10941104
- name: Set up NodeJs
10951105
uses: actions/setup-node@v4
10961106
with:

0 commit comments

Comments
 (0)