feat: implement deletion, add more tests

Author: ojongerius

src/dataLayer/mongo/communityEvent.js

@@ -6,7 +6,7 @@ import uuid from 'uuid/v4';
 import { isEmpty, isString } from 'lodash';
 
 import { asyncErrorHandler } from '../../utils';
-import { verifyWebToken, namespace, updateAppMetaData } from '../../auth';
+import { verifyWebToken } from '../../auth';
 import { isArray } from 'util';
 
 const log = debug('fcc:dataLayer:mongo:event');
@@ -35,22 +35,18 @@ function resolveAttendees(attendees) {
         return null;
       }
       */
-      // const attendee = await UserModel.findOne({externalId: attendeeUuid.externalId}, '_id');
+
       const attendee = await UserModel.findOne(attendeeUuid, '_id');
-      // const attendee = await UserModel.findOne(
-      //   { email: 'otto@a20.net' },
-      //   '_id'
-      // );
 
       if (attendee && !attendee.isEmpty) {
         resolvedAttendeesResult.push(attendee._id);
       } else {
-        reject(`Cant find attendee ${attendeeUuid}`);
+        reject(`Unable to find attendee: ${JSON.stringify(attendeeUuid)}`);
         return null;
       }
     }
 
-    return resolve(resolvedAttendeesResult);
+    resolve(resolvedAttendeesResult);
   });
 }
 
@@ -87,25 +83,25 @@ export async function getCommunityEvent(root, vars) {
     * consider builder pattern
     */
   if ('externalId' in vars && 'title in vars' in vars) {
+    if (!isString(vars.externalId) || !validator.isUUID(vars.externalId)) {
+      throw new TypeError(`Expected a valid UUID: ${vars.externalId}`);
+    }
     log(
       'both title and externalId in query, preferring externalId as ' +
         'it is more specific'
     );
-    if (!isString(vars.externalId) || !validator.isUUID(vars.externalId)) {
-      throw new TypeError('Not a valid UUID');
-    }
     query.externalId = vars.externalId;
   } else if ('externalId' in vars) {
-    log('searching by ID ' + vars.externalId);
     if (!isString(vars.externalId) || !validator.isUUID(vars.externalId)) {
-      throw new TypeError('Expected UUID');
+      throw new TypeError(`Expected a valid UUID: ${vars.externalId}`);
     }
+    log('searching by ID ' + vars.externalId);
     query.externalId = vars.externalId;
   } else if ('title' in vars) {
-    log('searching by title');
     if (!isString(vars.title)) {
-      throw new TypeError('Expected string');
+      throw new TypeError(`Expected a valid String: ${vars.title}`);
     }
+    log('searching by title');
     query.title = vars.title;
   } else {
     throw new TypeError('Expected an event ID or title');
@@ -127,7 +123,7 @@ export async function getCommunityEvents(root, vars) {
     * no console.log
     * consider builder pattern
 
-    Pagination
+    * Implement pagination
     */
   if ('externalId' in vars && 'title in vars' in vars) {
     console.log(
@@ -203,7 +199,7 @@ export async function createCommunityEvent(root, vars, ctx) {
     if ('isLocked' in vars) {
       if (!vars.isLocked.isString || validator.isBoolean(vars.isLocked)) {
         reject(
-          `Expected valid URL string, got ${JSON.stringify(vars.imageUrl)}`
+          `Expected a Boolean value, got ${JSON.stringify(vars.isLocked)}`
         );
         return null;
       }
@@ -213,14 +209,15 @@ export async function createCommunityEvent(root, vars, ctx) {
 
     if ('attendees' in vars) {
       event.attendees = await resolveAttendees(vars.attendees).catch(err => {
-        console.log('Oh oh could not resolve users, I should stop now..');
         reject(err);
         return null;
       });
+
+      if (!event.attendees) {
+        return null;
+      }
     }
 
-    // BUG: code below will even though our previous if statement returned null
-    // how does that work?
     const e = new CommunityEventModel(event);
 
     await e.save(err => {
@@ -229,8 +226,7 @@ export async function createCommunityEvent(root, vars, ctx) {
         return null;
       }
       /* Will have attendees populated at this point
-      Note that it interestingly this will *not* have an ID:
-      
+      Note that it interestingly this will *not* have an ID:    
       {
         "title":"another new event",
         "description":"cool event IV",
@@ -248,9 +244,47 @@ export async function createCommunityEvent(root, vars, ctx) {
   });
 }
 
-// Update an event
+// TODO: Update an event
 // export async function updateEvent(root, vars, ctx) {
 // }
 
 // Delete event, should only be allowed by creator and / or admin
-export async function deleteCommunityEvent(root, vars, ctx) {}
+export async function deleteCommunityEvent(root, vars, ctx) {
+  const { decoded } = verifyWebToken(ctx);
+  const { email } = decoded;
+
+  if (!isString(email) || !validator.isEmail(email)) {
+    throw new TypeError('You must provide a valid email');
+  }
+
+  // TODO: error handling
+  const user = await asyncErrorHandler(
+    UserModel.findOne({ email: email }, '_id').exec()
+  );
+
+  if ('externalId' in vars) {
+    if (!isString(vars.externalId) || !validator.isUUID(vars.externalId)) {
+      throw new TypeError('Not a valid UUID');
+    }
+  }
+
+  const event = await CommunityEventModel.findOne({
+    externalId: vars.externalId
+  }).exec();
+
+  if (isEmpty(event)) {
+    throw new Error('Event not found');
+  }
+
+  if (event.owner.externalId !== user.externalId) {
+    throw new Error('Only allowed to delete events you own');
+  }
+
+  const removedEvent = await CommunityEventModel.findOneAndRemove({
+    externalId: vars.externalId
+  });
+  if (!removedEvent) {
+    throw new Error(`No event with externalId ${vars.externalId}`);
+  }
+  return removedEvent;
+}