-
Notifications
You must be signed in to change notification settings - Fork 534
Can not pass multiple query parameters with same key name #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not a bug. Query parameters keys are supposed to be unique. |
Hello @animator !!!! With reference to some resources I would like to clarify what I was trying to point out:
Since both the server can read it and browser can produce it, thus to test the server side script, we should have the functionality in API Dash too. |
@royshruti Thanks for providing the explanation & relevant links. |
@animator For this to work we will need to update the expectation for codegen request models which are explicitly set to override here. /// GET request model with override query params
const requestModelGet3 = RequestModel(
id: 'get3',
url: 'https://api.apidash.dev/country/data?code=US',
method: HTTPVerb.get,
requestParams: [
NameValueModel(name: 'code', value: 'IND'),
],
); |
@animator I have fixed this issue.. are there any tests you want me to perform before opening a PR?.. Code from view Code - |
also i am not the one being Loyal to a single language (Multilingual). I can also upgrade codegen for other languages to handle multiple same params.. It would take only a day or two.This will also help me revise many things. query params having only the added params
or queryparams having all the params
|
You have to ensure existing tests are corrected and new tests are added for this feature. |
Query parameters having all params |
I'll make sure of it |
Describe the bug/problem
On passing multiple query parameters with the same key name but different values, only one persists in the final query parameter map. The value of this key is the last pair of key and value added in the Request section.
Bug Preview
Steps to Reproduce the bug/problem
Expected behavior
All the URL Parameters should be passed to the URL.
Device Info (The device where you encountered this issue):
The text was updated successfully, but these errors were encountered: