chore: fix ci (#182)

* try latest macos runner

* bump firestore-ios-sdk-frameworks version

* try reactivecircus/android-emulator-runner

* wip

* add manual invokation

* disable macos and ios

* default target

* tune target and arch

* api level 31

* uncomment actual wf

* add target and arch

* fix script

* fix working directory

* run flutter devices

* install flutter before flutter devices

* complete android setup

* use pixel 5

* enable ios and macos e2e

* use profile

* use anyIPv4

* move some email form tests from e2e to unit

* update avd cache key

* fix device name

* disable email link to anonymous user

* fix unit test

* fix sms code input error test

Author: lesnitsky

.github/workflows/e2e.yml

@@ -21,13 +21,26 @@ on:
       - "**.md"
       - "**.png"
       - "**.jpg"
+  workflow_dispatch:
 
 jobs:
   android:
-    runs-on: macos-13
+    runs-on: macos-latest
     timeout-minutes: 45
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
+      - name: Create AVD and generate snapshot for caching
+        if: steps.avd-cache.outputs.cache-hit != 'true'
+        uses: reactivecircus/android-emulator-runner@v2
+        with:
+          api-level: 31
+          force-avd-creation: false
+          emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
+          disable-animations: false
+          target: google_apis
+          arch: x86_64
+          profile: pixel_5
+          script: echo "Generated AVD snapshot for caching."
       - uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8
         name: Install Node.js 16
         with:
@@ -36,30 +49,27 @@ jobs:
         with:
           distribution: "temurin"
           java-version: "11"
-      - uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
-        name: Gradle Cache
-        with:
-          path: ~/.gradle/caches
-          key: ${{ runner.os }}-gradle-v4-${{ hashFiles('**/*.gradle*') }}
-          restore-keys: ${{ runner.os }}-gradle-v4
-      - uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
-        name: AVD Cache
+      - name: Gradle cache
+        uses: gradle/gradle-build-action@v2
+
+      - name: AVD cache
+        uses: actions/cache@v3
         id: avd-cache
         with:
           path: |
             ~/.android/avd/*
             ~/.android/adb*
-          key: avd
+          key: avd-pixel
+      - uses: subosito/flutter-action@48cafc24713cca54bbe03cdc3a423187d413aafa
+        with:
+          channel: "stable"
+          cache: true
       - name: Firebase Emulator Cache
         uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
         with:
           path: ~/.cache/firebase/emulators
           key: firebase-emulators-v2-${{ github.run_id }}
           restore-keys: firebase-emulators-v2
-      - uses: subosito/flutter-action@48cafc24713cca54bbe03cdc3a423187d413aafa
-        with:
-          channel: "stable"
-          cache: true
       - uses: bluefireteam/melos-action@dd3c344d731938d2ab2567a261f54a19a68b5f6a
         with:
           run-bootstrap: false
@@ -77,29 +87,21 @@ jobs:
           cd ../emulator_proxy
           echo "Starting emulator proxy"
           dart run emulator_proxy:start 100 &
-      - name: Create and start emulator
-        # We use the installed SDK in the macOS image to create and start the emulator
-        run: |
-          echo "List installed packages"
-          $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --list_installed
-
-          echo "Installing system image"
-          echo "y" | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager "system-images;android-33;google_apis;x86_64"
-
-          echo "Creating AVD"
-          echo "no" | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/avdmanager create avd -n test_emulator -k "system-images;android-33;google_apis;x86_64" --force --device "pixel_5"
-
-          echo "Starting emulator"
-          $ANDROID_SDK_ROOT/emulator/emulator -avd test_emulator -no-audio -no-boot-anim -no-window &
-          adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed) ]]; do sleep 1; done; input keyevent 82'
-      - name: "E2E Tests"
-        working-directory: tests
-        run: |
-          flutter test integration_test/firebase_ui_test.dart --dart-define=CI=true
+      - name: E2E Tests
+        uses: reactivecircus/android-emulator-runner@v2
+        with:
+          working-directory: tests
+          api-level: 31
+          force-avd-creation: false
+          emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
+          disable-animations: true
+          target: google_apis
+          arch: x86_64
+          profile: pixel_5
+          script: flutter devices && flutter test integration_test/firebase_ui_test.dart --dart-define=CI=true
 
   ios:
-    # Dropped down to macos-12 as macos-13 was timing out. This suspected issue:https://github.com/actions/runner-images/issues/8023
-    runs-on: macos-12
+    runs-on: macos-latest
     timeout-minutes: 45
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
@@ -176,7 +178,7 @@ jobs:
           flutter test ./integration_test/firebase_ui_test.dart -d "$SIMULATOR" --dart-define=CI=true
 
   macos:
-    runs-on: macos-13
+    runs-on: macos-latest
     timeout-minutes: 45
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11

emulator_proxy/lib/emulator_proxy.dart

@@ -19,7 +19,7 @@ class EmulatorProxy {
 
   Future<void> serve() async {
     final server = await HttpServer.bind(
-      InternetAddress.loopbackIPv4,
+      InternetAddress.anyIPv4,
       proxyPort,
     );
 

packages/firebase_ui_auth/test/widgets/email_form_test.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:firebase_ui_localizations/firebase_ui_localizations.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:firebase_ui_auth/firebase_ui_auth.dart';
@@ -15,6 +16,8 @@ import '../test_utils.dart';
 class MockFirebaseAuth extends Mock implements fba.FirebaseAuth {}
 
 void main() {
+  const labels = DefaultLocalizations();
+
   group('EmailForm', () {
     late Widget widget;
 
@@ -153,5 +156,128 @@ void main() {
         isFalse,
       );
     });
+
+    testWidgets('validates email', (tester) async {
+      await tester.pumpWidget(
+        TestMaterialApp(
+          child: EmailForm(
+            auth: MockAuth(),
+          ),
+        ),
+      );
+
+      final inputs = find.byType(TextFormField);
+      final emailInput = inputs.first;
+
+      await tester.enterText(emailInput, 'not a vailid email');
+      await tester.testTextInput.receiveAction(TextInputAction.done);
+      await tester.pumpAndSettle();
+
+      expect(find.text(labels.isNotAValidEmailErrorText), findsOneWidget);
+    });
+
+    testWidgets('requires password', (tester) async {
+      await tester.pumpWidget(
+        TestMaterialApp(
+          child: EmailForm(
+            auth: MockAuth(),
+          ),
+        ),
+      );
+
+      final inputs = find.byType(TextFormField);
+      final emailInput = inputs.first;
+      final passwordInput = inputs.at(1);
+
+      await tester.enterText(emailInput, '[email protected]');
+      await tester.testTextInput.receiveAction(TextInputAction.done);
+
+      await tester.enterText(passwordInput, '');
+      await tester.pumpAndSettle();
+
+      expect(find.text(labels.passwordIsRequiredErrorText), findsOneWidget);
+    });
+
+    testWidgets(
+      'shows password confirmation if action is sign up',
+      (tester) async {
+        await tester.pumpWidget(
+          TestMaterialApp(
+            child: EmailForm(
+              auth: MockAuth(),
+              action: AuthAction.signUp,
+            ),
+          ),
+        );
+
+        final inputs = find.byType(TextFormField);
+        expect(inputs, findsNWidgets(3));
+      },
+    );
+
+    testWidgets(
+      'requires password confirmation',
+      (tester) async {
+        await tester.pumpWidget(
+          TestMaterialApp(
+            child: EmailForm(
+              auth: MockAuth(),
+              action: AuthAction.signUp,
+            ),
+          ),
+        );
+
+        final inputs = find.byType(TextFormField);
+
+        await tester.enterText(inputs.at(0), '[email protected]');
+        await tester.testTextInput.receiveAction(TextInputAction.done);
+
+        await tester.enterText(inputs.at(1), 'password');
+        await tester.testTextInput.receiveAction(TextInputAction.done);
+
+        await tester.enterText(inputs.at(2), '');
+        await tester.testTextInput.receiveAction(TextInputAction.done);
+
+        await tester.pumpAndSettle();
+
+        expect(
+          find.text(labels.confirmPasswordIsRequiredErrorText),
+          findsOneWidget,
+        );
+      },
+    );
+
+    testWidgets(
+      'verifies that password confirmation matches password',
+      (tester) async {
+        await tester.pumpWidget(
+          TestMaterialApp(
+            child: EmailForm(
+              auth: MockAuth(),
+              action: AuthAction.signUp,
+            ),
+          ),
+        );
+
+        final inputs = find.byType(TextFormField);
+
+        await tester.enterText(inputs.at(0), '[email protected]');
+        await tester.testTextInput.receiveAction(TextInputAction.done);
+        await tester.pump();
+
+        await tester.enterText(inputs.at(1), 'password');
+        await tester.testTextInput.receiveAction(TextInputAction.done);
+        await tester.pump();
+
+        await tester.enterText(inputs.at(2), 'psasword');
+        await tester.testTextInput.receiveAction(TextInputAction.done);
+        await tester.pumpAndSettle();
+
+        expect(
+          find.text(labels.confirmPasswordDoesNotMatchErrorText),
+          findsOneWidget,
+        );
+      },
+    );
   });
 }